From 4b7c6dda0752707256711b4ab67fb2b0718aaffb Mon Sep 17 00:00:00 2001
From: Ahmad <103906421+ahmadk953@users.noreply.github.com>
Date: Tue, 24 Jun 2025 20:31:45 -0400
Subject: [PATCH] chore(bot): update caching logic

---
 src/db/functions/achievementFunctions.ts | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/db/functions/achievementFunctions.ts b/src/db/functions/achievementFunctions.ts
index f71df89..7e3440c 100644
--- a/src/db/functions/achievementFunctions.ts
+++ b/src/db/functions/achievementFunctions.ts
@@ -112,22 +112,17 @@ export async function updateAchievementProgress(
       await db
         .update(schema.userAchievementsTable)
         .set({ progress, earnedAt: progress === 100 ? new Date() : null })
-        .where(eq(schema.userAchievementsTable.id, existing.id))
-        .returning();
+        .where(eq(schema.userAchievementsTable.id, existing.id));
     } else {
-      await db
-        .insert(schema.userAchievementsTable)
-        .values({
-          discordId: userId,
-          achievementId,
-          progress,
-          earnedAt: progress === 100 ? new Date() : null,
-        })
-        .returning();
+      await db.insert(schema.userAchievementsTable).values({
+        discordId: userId,
+        achievementId,
+        progress,
+        earnedAt: progress === 100 ? new Date() : null,
+      });
     }
 
     await invalidateCache(`userAchievements:${userId}`);
-    await getUserAchievements(userId);
 
     return true;
   } catch (error) {
@@ -173,7 +168,6 @@ export async function createAchievement(achievementData: {
       .returning();
 
     await invalidateCache('achievementDefinitions');
-    await getAllAchievements();
 
     return achievement;
   } catch (error) {
@@ -205,7 +199,6 @@ export async function deleteAchievement(
       .where(eq(schema.achievementDefinitionsTable.id, achievementId));
 
     await invalidateCache('achievementDefinitions');
-    await getAllAchievements();
 
     return true;
   } catch (error) {
@@ -241,7 +234,6 @@ export async function removeUserAchievement(
       );
 
     await invalidateCache(`userAchievements:${discordId}`);
-    await getUserAchievements(discordId);
 
     return true;
   } catch (error) {