From d0547ec10668c834c6b8843a678b174d710e136b Mon Sep 17 00:00:00 2001 From: cuom1999 Date: Fri, 28 Oct 2022 22:34:12 -0500 Subject: [PATCH] Limit submission page to 50000 --- judge/views/organization.py | 4 ++-- judge/views/submission.py | 26 ++++++++++++++++---------- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/judge/views/organization.py b/judge/views/organization.py index c2b1435..b61569e 100644 --- a/judge/views/organization.py +++ b/judge/views/organization.py @@ -449,10 +449,10 @@ class OrganizationSubmissions( def contest(self): return None - def get_queryset(self): + def _get_queryset(self): return ( super() - ._get_queryset() + ._get_entire_queryset() .filter(contest_object__organizations=self.organization) ) diff --git a/judge/views/submission.py b/judge/views/submission.py index bf0dac9..5b8ee3e 100644 --- a/judge/views/submission.py +++ b/judge/views/submission.py @@ -51,6 +51,9 @@ from judge.utils.views import TitleMixin from judge.utils.timedelta import nice_repr +MAX_NUMBER_OF_QUERY_SUBMISSIONS = 50000 + + def submission_related(queryset): return queryset.select_related("user__user", "problem", "language").only( "id", @@ -306,7 +309,7 @@ class SubmissionsListBase(DiggPaginatorMixin, TitleMixin, ListView): return result def _get_result_data(self): - return get_result_data(self.get_queryset().order_by()) + return get_result_data(self._get_queryset().order_by()) def access_check(self, request): pass @@ -323,7 +326,7 @@ class SubmissionsListBase(DiggPaginatorMixin, TitleMixin, ListView): def contest(self): return self.request.profile.current_contest.contest - def _get_queryset(self): + def _get_entire_queryset(self): queryset = Submission.objects.all() use_straight_join(queryset) queryset = submission_related(queryset.order_by("-id")) @@ -374,8 +377,8 @@ class SubmissionsListBase(DiggPaginatorMixin, TitleMixin, ListView): return queryset - def get_queryset(self): - queryset = self._get_queryset() + def _get_queryset(self): + queryset = self._get_entire_queryset() if not self.in_contest: join_sql_subquery( queryset, @@ -391,6 +394,9 @@ class SubmissionsListBase(DiggPaginatorMixin, TitleMixin, ListView): ) return queryset + def get_queryset(self): + return self._get_queryset()[:MAX_NUMBER_OF_QUERY_SUBMISSIONS] + def get_my_submissions_page(self): return None @@ -476,10 +482,10 @@ class ConditionalUserTabMixin(object): class AllUserSubmissions(ConditionalUserTabMixin, UserMixin, SubmissionsListBase): - def get_queryset(self): + def _get_queryset(self): return ( super(AllUserSubmissions, self) - .get_queryset() + ._get_queryset() .filter(user_id=self.profile.id) ) @@ -516,7 +522,7 @@ class ProblemSubmissionsBase(SubmissionsListBase): dynamic_update = True check_contest_in_access_check = False - def get_queryset(self): + def _get_queryset(self): if ( self.in_contest and not self.contest.contest_problems.filter( @@ -526,7 +532,7 @@ class ProblemSubmissionsBase(SubmissionsListBase): raise Http404() return ( super(ProblemSubmissionsBase, self) - ._get_queryset() + ._get_entire_queryset() .filter(problem_id=self.problem.id) ) @@ -608,10 +614,10 @@ class UserProblemSubmissions(ConditionalUserTabMixin, UserMixin, ProblemSubmissi if not self.is_own: self.access_check_contest(request) - def get_queryset(self): + def _get_queryset(self): return ( super(UserProblemSubmissions, self) - .get_queryset() + ._get_queryset() .filter(user_id=self.profile.id) )