skyfall/rtl8188eu
1
0
Fork 0
mirror of https://github.com/lwfinger/rtl8188eu.git synced 2024-11-22 12:33:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update Makefile to not error if repo was cloned using Sapling

Browse source 
This changes the `test` Makefile target conditional to pass for Sapling cloned repos.

I was building this locally and ran into this issue because I cloned the repo using Sapling (https://sapling-scm.com) which uses a `.sl` directory at the repo root as opposed to a `.git` directory, and as such got the error message about zip files. Getting around the message was just making an empty top level `.git` directory, but IMO it shouldn't show this error in the first place.

As of now, this would also fail with for Mercurial cloned repos (which uses a `.hg` directory). I thought of generalizing it to check for any hidden top level directory, but technically `.git` can be a can be a text file (see: https://git-scm.com/docs/gitrepository-layout)

Also, I opted to not change the message printed in the failure case to include this as it might cause more confusion than benefit.
This commit is contained in:
Genevieve Helsel 2024-04-14 00:18:09 -07:00
parent f5d1c8df2e
commit 0f68189028
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile
View file

@ -149,7 +149,7 @@ endif
all: test modules all: test modules
test: test:
@if [ ! -e ./.git ] ; then echo $(MSG); exit 1; fi; @if [ ! -e ./.git -a ! -e ./.sl ] ; then echo $(MSG); exit 1; fi;
modules: modules:
$(MAKE) ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C $(KSRC) M=$(shell pwd) modules $(MAKE) ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C $(KSRC) M=$(shell pwd) modules