From a5e071f8daeac9365b258357111225bd6149af1e Mon Sep 17 00:00:00 2001 From: Larry Finger Date: Thu, 5 Sep 2013 22:32:25 -0500 Subject: [PATCH] rtl8188eu: Fix smatch warnings in hal/rtl8188e_hal_init.c Smatch displays the following: CHECK /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:1695 hal_EfusePgPacketWriteData() info: ignoring unreachable code. /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2269 Hal_ReadPowerValueFromPROM_8188E() error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5 /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2466 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14 /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2468 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14 /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2474 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14 /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2475 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14 Signed-off-by: Larry Finger --- hal/rtl8188e_hal_init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hal/rtl8188e_hal_init.c b/hal/rtl8188e_hal_init.c index f990a3d..2f42b84 100644 --- a/hal/rtl8188e_hal_init.c +++ b/hal/rtl8188e_hal_init.c @@ -1674,7 +1674,6 @@ static bool hal_EfusePgPacketWrite1ByteHeader(struct adapter *pAdapter, u8 efuse static bool hal_EfusePgPacketWriteData(struct adapter *pAdapter, u8 efuseType, u16 *pAddr, struct pgpkt *pTargetPkt, bool bPseudoTest) { - bool bRet = false; u16 efuse_addr = *pAddr; u8 badworden = 0; u32 PgWriteSuccess = 0; @@ -1692,7 +1691,6 @@ static bool hal_EfusePgPacketWriteData(struct adapter *pAdapter, u8 efuseType, u else return true; } - return bRet; } static bool @@ -2460,7 +2458,7 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter, u8 *PROMContent, bool Auto pHalData->bTXPowerDataReadFromEEPORM = true; for (rfPath = 0; rfPath < pHalData->NumTotalRFPath; rfPath++) { - for (ch = 0; ch <= CHANNEL_MAX_NUMBER; ch++) { + for (ch = 0; ch < CHANNEL_MAX_NUMBER; ch++) { bIn24G = Hal_GetChnlGroup88E(ch, &group); if (bIn24G) { pHalData->Index24G_CCK_Base[rfPath][ch] = pwrInfo24G.IndexCCK_Base[rfPath][group];