rtl8188eu: Fix a number of sparse warnings

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
This commit is contained in:
Larry Finger 2018-11-01 20:34:15 -05:00
parent 96ff2341a9
commit bf88fed9a4
33 changed files with 340 additions and 318 deletions

View file

@ -1,7 +1,7 @@
#include "btc/mp_precomp.h"
#include <hal_btcoex_wifionly.h>
struct wifi_only_cfg GLBtCoexistWifiOnly;
static struct wifi_only_cfg GLBtCoexistWifiOnly;
void halwifionly_write1byte(PVOID pwifionlyContext, u32 RegAddr, u8 Data)
{

View file

@ -53,7 +53,7 @@
#endif /* !RTW_HALMAC */
u8 MgntQuery_NssTxRate(u16 Rate)
static u8 MgntQuery_NssTxRate(u16 Rate)
{
u8 NssNum = RF_TX_NUM_NONIMPLEMENT;
@ -349,7 +349,7 @@ void hal_mpt_SetBandwidth(PADAPTER pAdapter)
hal_mpt_SwitchRfSetting(pAdapter);
}
void mpt_SetTxPower_Old(PADAPTER pAdapter, MPT_TXPWR_DEF Rate, u8 *pTxPower)
static void mpt_SetTxPower_Old(PADAPTER pAdapter, MPT_TXPWR_DEF Rate, u8 *pTxPower)
{
switch (Rate) {
case MPT_CCK: {
@ -407,7 +407,7 @@ void mpt_SetTxPower_Old(PADAPTER pAdapter, MPT_TXPWR_DEF Rate, u8 *pTxPower)
RTW_INFO("<===mpt_SetTxPower_Old()\n");
}
void
static void
mpt_SetTxPower(
PADAPTER pAdapter,
MPT_TXPWR_DEF Rate,
@ -1263,7 +1263,7 @@ void mpt_SetRFPath_8723D(PADAPTER pAdapter)
}
#endif
VOID mpt_SetRFPath_819X(PADAPTER pAdapter)
static void mpt_SetRFPath_819X(PADAPTER pAdapter)
{
HAL_DATA_TYPE *pHalData = GET_HAL_DATA(pAdapter);
PMPT_CONTEXT pMptCtx = &(pAdapter->mppriv.mpt_ctx);

View file

@ -249,9 +249,9 @@ int usb_async_write8(struct intf_hdl *pintfhdl, u32 addr, u8 val)
return ret;
}
int usb_async_write16(struct intf_hdl *pintfhdl, u32 addr, u16 val)
int usb_async_write16(struct intf_hdl *pintfhdl, u32 addr, __le16 val)
{
u16 data;
__le16 data;
int ret;
struct dvobj_priv *pdvobjpriv = (struct dvobj_priv *)pintfhdl->pintf_dev;
struct usb_device *udev = pdvobjpriv->pusbdev;
@ -304,7 +304,7 @@ u16 usb_read16(struct intf_hdl *pintfhdl, u32 addr)
u16 wvalue;
u16 index;
u16 len;
u16 data = 0;
__le16 data = 0;
request = 0x05;
requesttype = 0x01;/* read_in */
@ -315,8 +315,7 @@ u16 usb_read16(struct intf_hdl *pintfhdl, u32 addr)
usbctrl_vendorreq(pintfhdl, request, wvalue, index,
&data, len, requesttype);
return data;
return le16_to_cpu(data);
}
u32 usb_read32(struct intf_hdl *pintfhdl, u32 addr)
@ -326,7 +325,7 @@ u32 usb_read32(struct intf_hdl *pintfhdl, u32 addr)
u16 wvalue;
u16 index;
u16 len;
u32 data = 0;
__le32 data = 0;
request = 0x05;
requesttype = 0x01;/* read_in */
@ -337,7 +336,7 @@ u32 usb_read32(struct intf_hdl *pintfhdl, u32 addr)
usbctrl_vendorreq(pintfhdl, request, wvalue, index,
&data, len, requesttype);
return data;
return le32_to_cpu(data);
}
int usb_write8(struct intf_hdl *pintfhdl, u32 addr, u8 val)
@ -364,14 +363,14 @@ int usb_write8(struct intf_hdl *pintfhdl, u32 addr, u8 val)
return ret;
}
int usb_write16(struct intf_hdl *pintfhdl, u32 addr, u16 val)
int usb_write16(struct intf_hdl *pintfhdl, u32 addr, __le16 val)
{
u8 request;
u8 requesttype;
u16 wvalue;
u16 index;
u16 len;
u16 data;
__le16 data;
int ret;
request = 0x05;
@ -389,14 +388,14 @@ int usb_write16(struct intf_hdl *pintfhdl, u32 addr, u16 val)
}
int usb_write32(struct intf_hdl *pintfhdl, u32 addr, u32 val)
int usb_write32(struct intf_hdl *pintfhdl, u32 addr, __le32 val)
{
u8 request;
u8 requesttype;
u16 wvalue;
u16 index;
u16 len;
u32 data;
__le32 data;
int ret;
request = 0x05;

View file

@ -26,7 +26,7 @@
* Implementation of LED blinking behavior.
* It toggle off LED and schedule corresponding timer if necessary.
* */
void
static void
SwLedBlink(
PLED_USB pLed
)
@ -116,7 +116,7 @@ SwLedBlink(
}
}
void
static void
SwLedBlink1(
PLED_USB pLed
)
@ -293,7 +293,7 @@ SwLedBlink1(
}
void
static void
SwLedBlink2(
PLED_USB pLed
)
@ -379,7 +379,7 @@ SwLedBlink2(
}
void
static void
SwLedBlink3(
PLED_USB pLed
)
@ -505,7 +505,7 @@ SwLedBlink3(
}
void
static void
SwLedBlink4(
PLED_USB pLed
)
@ -693,7 +693,7 @@ SwLedBlink4(
}
void
static void
SwLedBlink5(
PLED_USB pLed
)
@ -783,7 +783,7 @@ SwLedBlink5(
}
void
static void
SwLedBlink6(
PLED_USB pLed
)
@ -801,7 +801,7 @@ SwLedBlink6(
}
void
static void
SwLedBlink7(
PLED_USB pLed
)
@ -890,7 +890,7 @@ SwLedBlink7(
}
void
static void
SwLedBlink8(
PLED_USB pLed
)
@ -908,7 +908,7 @@ SwLedBlink8(
}
/* page added for Belkin AC950. 20120813 */
void
static void
SwLedBlink9(
PLED_USB pLed
)
@ -1144,7 +1144,7 @@ SwLedBlink9(
}
/* page added for Netgear A6200V2. 20120827 */
void
static void
SwLedBlink10(
PLED_USB pLed
)
@ -1340,11 +1340,9 @@ SwLedBlink10(
default:
break;
}
}
void
static void
SwLedBlink11(
PLED_USB pLed
)
@ -1415,7 +1413,7 @@ SwLedBlink11(
}
void
static void
SwLedBlink12(
PLED_USB pLed
)
@ -1483,7 +1481,7 @@ SwLedBlink12(
}
VOID
static void
SwLedBlink13(
IN PLED_USB pLed
)
@ -1544,7 +1542,7 @@ SwLedBlink13(
}
VOID
static void
SwLedBlink14(
IN PLED_USB pLed
)
@ -1601,7 +1599,7 @@ SwLedBlink14(
}
VOID
static void
SwLedBlink15(
IN PLED_USB pLed
)
@ -2914,7 +2912,7 @@ SwLedControlMode6(
}
/* Netgear, added by sinda, 2011/11/11 */
void
static void
SwLedControlMode7(
PADAPTER Adapter,
LED_CTL_MODE LedAction
@ -3053,7 +3051,7 @@ SwLedControlMode7(
}
void
static void
SwLedControlMode8(
PADAPTER Adapter,
LED_CTL_MODE LedAction
@ -3090,7 +3088,7 @@ SwLedControlMode8(
}
/* page added for Belkin AC950, 20120813 */
void
static void
SwLedControlMode9(
IN PADAPTER Adapter,
IN LED_CTL_MODE LedAction
@ -3392,7 +3390,7 @@ SwLedControlMode9(
}
/* page added for Netgear A6200V2, 20120827 */
void
static void
SwLedControlMode10(
PADAPTER Adapter,
LED_CTL_MODE LedAction
@ -3590,7 +3588,7 @@ SwLedControlMode10(
}
/* Edimax-ASUS, added by Page, 20121221 */
void
static void
SwLedControlMode11(
PADAPTER Adapter,
LED_CTL_MODE LedAction
@ -3689,7 +3687,7 @@ SwLedControlMode11(
/* page added for NEC */
VOID
static void
SwLedControlMode12(
PADAPTER Adapter,
LED_CTL_MODE LedAction
@ -3770,7 +3768,7 @@ SwLedControlMode12(
/* Maddest add for NETGEAR R6100 */
VOID
static void
SwLedControlMode13(
IN PADAPTER Adapter,
IN LED_CTL_MODE LedAction
@ -3916,7 +3914,7 @@ SwLedControlMode13(
/* Maddest add for DNI Buffalo */
VOID
static void
SwLedControlMode14(
IN PADAPTER Adapter,
IN LED_CTL_MODE LedAction
@ -3975,7 +3973,7 @@ SwLedControlMode14(
/* Maddest add for Dlink */
VOID
static void
SwLedControlMode15(
IN PADAPTER Adapter,
IN LED_CTL_MODE LedAction

View file

@ -148,7 +148,7 @@ exit:
return ret;
}
u8 rtl8192c_h2c_msg_hdl(_adapter *padapter, unsigned char *pbuf)
static u8 rtl8192c_h2c_msg_hdl(_adapter *padapter, unsigned char *pbuf)
{
u8 ElementID, CmdLen;
u8 *pCmdBuffer;
@ -190,10 +190,9 @@ u8 rtl8188e_set_rssi_cmd(_adapter *padapter, u8 *param)
return _FAIL;
}
*((u32 *) param) = cpu_to_le32(*((u32 *) param));
*((__le32 *) param) = cpu_to_le32(*((u32 *) param));
FillH2CCmd_88E(padapter, H2C_RSSI_REPORT, 3, param);
return res;
}
@ -320,11 +319,11 @@ void rtl8188e_set_FwPwrMode_cmd(PADAPTER padapter, u8 Mode)
}
void ConstructBeacon(_adapter *padapter, u8 *pframe, u32 *pLength)
static void ConstructBeacon(_adapter *padapter, u8 *pframe, u32 *pLength)
{
struct rtw_ieee80211_hdr *pwlanhdr;
u16 *fctrl;
u32 rate_len, pktlen;
__le16 *fctrl;
u32 rate_len, pktlen;
struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
WLAN_BSSID_EX *cur_network = &(pmlmeinfo->network);
@ -417,11 +416,11 @@ _ConstructBeacon:
}
void ConstructPSPoll(_adapter *padapter, u8 *pframe, u32 *pLength)
static void ConstructPSPoll(_adapter *padapter, u8 *pframe, u32 *pLength)
{
struct rtw_ieee80211_hdr *pwlanhdr;
u16 *fctrl;
u32 pktlen;
__le16 *fctrl;
u32 pktlen;
struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
@ -447,7 +446,7 @@ void ConstructPSPoll(_adapter *padapter, u8 *pframe, u32 *pLength)
*pLength = 16;
}
void ConstructNullFunctionData(
static void ConstructNullFunctionData(
PADAPTER padapter,
u8 *pframe,
u32 *pLength,
@ -458,8 +457,8 @@ void ConstructNullFunctionData(
u8 bForcePowerSave)
{
struct rtw_ieee80211_hdr *pwlanhdr;
u16 *fctrl;
u32 pktlen;
__le16 *fctrl;
u32 pktlen;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_network *cur_network = &pmlmepriv->cur_network;
struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
@ -517,7 +516,7 @@ void ConstructNullFunctionData(
*pLength = pktlen;
}
void rtl8188e_set_FwRsvdPage_cmd(PADAPTER padapter, PRSVDPAGE_LOC rsvdpageloc)
static void rtl8188e_set_FwRsvdPage_cmd(PADAPTER padapter, PRSVDPAGE_LOC rsvdpageloc)
{
u8 u1H2CRsvdPageParm[H2C_RSVDPAGE_LOC_LEN] = {0};
u8 u1H2CAoacRsvdPageParm[H2C_AOAC_RSVDPAGE_LOC_LEN] = {0};

View file

@ -251,7 +251,7 @@ exit:
rtw_mfree2d((void *)eFuseWord, EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(u16));
}
void efuse_read_phymap_from_txpktbuf(
static void efuse_read_phymap_from_txpktbuf(
ADAPTER *adapter,
int bcnhead, /* beacon head, where FW store len(2-byte) and efuse physical map. */
u8 *content, /* buffer to store efuse physical map */
@ -323,11 +323,11 @@ void efuse_read_phymap_from_txpktbuf(
lenc[0] = rtw_read8(adapter, REG_PKTBUF_DBG_DATA_L);
lenc[1] = rtw_read8(adapter, REG_PKTBUF_DBG_DATA_L + 1);
aaabak = le16_to_cpup((u16 *)lenc);
lenbak = le16_to_cpu(*((u16 *)lenc));
aaa = le16_to_cpup((u16 *)&lo32);
aaabak = le16_to_cpup((__le16 *)lenc);
lenbak = le16_to_cpu(*((__le16 *)lenc));
aaa = le16_to_cpup((__le16 *)&lo32);
#endif
len = le16_to_cpu(*((u16 *)&lo32));
len = le16_to_cpu(*((__le16 *)&lo32));
limit = (len - 2 < limit) ? len - 2 : limit;
@ -445,7 +445,7 @@ static s32 iol_ioconfig(
return rst;
}
int rtl8188e_IOL_exec_cmds_sync(ADAPTER *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt)
static int rtl8188e_IOL_exec_cmds_sync(ADAPTER *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt)
{
u32 start_time = rtw_get_current_time();
@ -733,7 +733,7 @@ exit:
return ret;
}
void _MCUIO_Reset88E(PADAPTER padapter, u8 bReset)
static void _MCUIO_Reset88E(PADAPTER padapter, u8 bReset)
{
u8 u1bTmp;
@ -968,8 +968,9 @@ s32 rtl8188e_FirmwareDownload(PADAPTER padapter, BOOLEAN bUsedWoWLANFw)
pHalData->FirmwareSignature = le16_to_cpu(pFwHdr->Signature);
RTW_INFO("%s: fw_ver=%x fw_subver=%04x sig=0x%x, Month=%02x, Date=%02x, Hour=%02x, Minute=%02x\n",
__FUNCTION__, pHalData->firmware_version, pHalData->firmware_sub_version, pHalData->FirmwareSignature
, pFwHdr->Month, pFwHdr->Date, pFwHdr->Hour, pFwHdr->Minute);
__func__, pHalData->firmware_version,
pHalData->firmware_sub_version, pHalData->FirmwareSignature,
pFwHdr->Month, pFwHdr->Date, pFwHdr->Hour, pFwHdr->Minute);
if (IS_FW_HEADER_EXIST_88E(pFwHdr)) {
/* Shift 32 bytes for FW header */
@ -1466,7 +1467,7 @@ rtl8188e_ReadEFuse(
}
/* Do not support BT */
VOID
static void
Hal_EFUSEGetEfuseDefinition88E(
IN PADAPTER pAdapter,
IN u1Byte efuseType,
@ -1525,7 +1526,8 @@ Hal_EFUSEGetEfuseDefinition88E(
break;
}
}
VOID
static void
Hal_EFUSEGetEfuseDefinition_Pseudo88E(
IN PADAPTER pAdapter,
IN u8 efuseType,
@ -2497,7 +2499,8 @@ void rtl8188e_stop_thread(_adapter *padapter)
#endif
#endif
}
void hal_notch_filter_8188e(_adapter *adapter, bool enable)
static void hal_notch_filter_8188e(_adapter *adapter, bool enable)
{
if (enable) {
RTW_INFO("Enable notch filter\n");
@ -2508,7 +2511,7 @@ void hal_notch_filter_8188e(_adapter *adapter, bool enable)
}
}
void update_ra_mask_8188e(_adapter *padapter, struct sta_info *psta, struct macid_cfg *h2c_macid_cfg)
static void update_ra_mask_8188e(_adapter *padapter, struct sta_info *psta, struct macid_cfg *h2c_macid_cfg)
{
HAL_DATA_TYPE *hal_data = GET_HAL_DATA(padapter);
@ -2679,7 +2682,7 @@ u8 GetEEPROMSize8188E(PADAPTER padapter)
* LLT R/W/Init function
*
* ------------------------------------------------------------------------- */
s32 _LLTWrite(PADAPTER padapter, u32 address, u32 data)
static s32 _LLTWrite(PADAPTER padapter, u32 address, u32 data)
{
s32 status = _SUCCESS;
s8 count = POLLING_LLT_THRESHOLD;
@ -2702,7 +2705,7 @@ s32 _LLTWrite(PADAPTER padapter, u32 address, u32 data)
return status;
}
u8 _LLTRead(PADAPTER padapter, u32 address)
static u8 _LLTRead(PADAPTER padapter, u32 address)
{
s32 count = POLLING_LLT_THRESHOLD;
u32 value = _LLT_INIT_ADDR(address) | _LLT_OP(_LLT_READ_ACCESS);
@ -2815,7 +2818,7 @@ Hal_EfuseParseIDCode88E(
/* Checl 0x8129 again for making sure autoload status!! */
EEPROMId = le16_to_cpu(*((u16 *)hwinfo));
EEPROMId = le16_to_cpu(*((__le16 *)hwinfo));
if (EEPROMId != RTL_EEPROM_ID) {
RTW_INFO("EEPROM ID(%#x) is invalid!!\n", EEPROMId);
pHalData->bautoload_fail_flag = _TRUE;
@ -4583,7 +4586,7 @@ struct bcn_qinfo_88e {
u16 pkt_num:8;
};
void dump_qinfo_88e(void *sel, struct qinfo_88e *info, const char *tag)
static void dump_qinfo_88e(void *sel, struct qinfo_88e *info, const char *tag)
{
/* if (info->pkt_num) */
RTW_PRINT_SEL(sel, "%shead:0x%02x, tail:0x%02x, pkt_num:%u, macid:%u, ac:%u\n"
@ -4591,7 +4594,7 @@ void dump_qinfo_88e(void *sel, struct qinfo_88e *info, const char *tag)
);
}
void dump_bcn_qinfo_88e(void *sel, struct bcn_qinfo_88e *info, const char *tag)
static void dump_bcn_qinfo_88e(void *sel, struct bcn_qinfo_88e *info, const char *tag)
{
/* if (info->pkt_num) */
RTW_PRINT_SEL(sel, "%shead:0x%02x, pkt_num:%u\n"
@ -4599,7 +4602,7 @@ void dump_bcn_qinfo_88e(void *sel, struct bcn_qinfo_88e *info, const char *tag)
);
}
void dump_mac_qinfo_88e(void *sel, _adapter *adapter)
static void dump_mac_qinfo_88e(void *sel, _adapter *adapter)
{
u32 q0_info;
u32 q1_info;
@ -4693,7 +4696,8 @@ void GetHwReg8188E(_adapter *adapter, u8 variable, u8 *val)
}
}
void hal_ra_info_dump(_adapter *padapter , void *sel)
static void hal_ra_info_dump(_adapter *padapter , void *sel)
{
int i;
u8 mac_id;

View file

@ -290,7 +290,7 @@ void fill_txdesc_force_bmc_camid(struct pkt_attrib *pattrib, struct tx_desc *ptx
void rtl8188e_cal_txdesc_chksum(struct tx_desc *ptxdesc)
{
u16 *usPtr = (u16 *)ptxdesc;
__le16 *usPtr = (__le16 *)ptxdesc;
u32 count = 16; /* (32 bytes / 2 bytes per XOR) => 16 times */
u32 index;
u16 checksum = 0;