skyfall/rtl8188eu
1
0
Fork 0
mirror of https://github.com/lwfinger/rtl8188eu.git synced 2024-11-10 07:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rtl8188eu: Fix Sparse errors in os_dep/ioctl_linux.c

Browse source 
The following Sparse warnings are output:

  CHECK   /home/finger/rtl8188eu/os_dep/ioctl_linux.c
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3184:9: warning: context imbalance in 'rtw_get_ap_info' - different lock contexts for basic block
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3916:9: warning: context imbalance in 'rtw_p2p_get_go_device_address' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4063:9: warning: context imbalance in 'rtw_p2p_get_device_name' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4146:9: warning: context imbalance in 'rtw_p2p_get_invitation_procedure' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:6879:12: warning: context imbalance in 'rtw_del_sta' - different lock contexts for basic block

Each of these is a real error caused by improper use of a spin lock when
 a spin unlock is needed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
This commit is contained in:
Larry Finger 2015-08-14 19:35:20 -05:00
parent 16ab32d5e3
commit c8bd30ee46
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
os_dep/ioctl_linux.c
View file

@ -3170,7 +3170,7 @@ static int rtw_get_ap_info(struct net_device *dev,
}
spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
if(pdata->length>=34) {
if(copy_to_user((u8 __user *)pdata->pointer+32, (u8*)&pdata->flags, 1)) {
@ -3904,7 +3904,7 @@ static int rtw_p2p_get_go_device_address(struct net_device *dev,
}
spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
if (!blnMatch) {
sprintf(go_devadd_str, "\n\ndev_add=NULL");
@ -4055,7 +4055,7 @@ static int rtw_p2p_get_device_name(struct net_device *dev,
}
spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
if (!blnMatch)
sprintf(dev_name_str, "\n\nN=0000");
@ -4132,7 +4132,7 @@ static int rtw_p2p_get_invitation_procedure(struct net_device *dev,
}
spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
if (!blnMatch) {
sprintf(inv_proc_str, "\nIP=-1");
@ -6911,7 +6911,7 @@ static int rtw_del_sta(struct net_device *dev, struct ieee_param *param)
pstapriv->asoc_list_cnt--;
updated = ap_free_sta(padapter, psta, true, WLAN_REASON_DEAUTH_LEAVING);
}
spin_lock_bh(&pstapriv->asoc_list_lock);
spin_unlock_bh(&pstapriv->asoc_list_lock);
associated_clients_update(padapter, updated);