From cc88df7da3771a213e6f14f9af6d46d1946d5488 Mon Sep 17 00:00:00 2001 From: Larry Finger Date: Fri, 14 Aug 2015 22:56:49 -0500 Subject: [PATCH] rtl8188eu: Fix Sparse problems in core/rtw_mlme_ext.c Sparse reports the following: CHECK /home/finger/rtl8188eu/core/rtw_mlme_ext.c /home/finger/rtl8188eu/core/rtw_mlme_ext.c:9446:6: warning: symbol '_linked_rx_signal_strehgth_display' was not declared. Should it be static? /home/finger/rtl8188eu/core/rtw_mlme_ext.c:8520:6: warning: context imbalance in 'start_clnt_join' - different lock contexts for basic block The second warning was due to the failure to unlock a spin lock in a error path. Signed-off-by: Larry Finger --- core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/rtw_mlme_ext.c b/core/rtw_mlme_ext.c index 7d944ee..2570b27 100644 --- a/core/rtw_mlme_ext.c +++ b/core/rtw_mlme_ext.c @@ -8562,6 +8562,7 @@ void start_clnt_join(struct adapter* padapter) scanned = LIST_CONTAINOR(pos, struct wlan_network, list); if(scanned==NULL) { + spin_unlock_bh(&(padapter->mlmepriv.scanned_queue.lock)); rtw_warn_on(1); return; } @@ -9443,7 +9444,7 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter) Following are the functions for the timer handlers *****************************************************************************/ -void _linked_rx_signal_strehgth_display(struct adapter *padapter) +static void _linked_rx_signal_strehgth_display(struct adapter *padapter) { struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);