skyfall/rtl8188eu
1
0
Fork 0
mirror of https://github.com/lwfinger/rtl8188eu.git synced 2024-11-10 07:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
rtl8188eu/core
History
Larry Finger 65c4e60be3 rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c 
Smatch reports the following problems:
  CHECK   /home/finger/rtl8188eu/core/rtw_ioctl_set.c
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:593 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:595 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:745 rtw_set_802_11_add_key() warn: was && intended here instead of ||?

The buffer overflow messages are due to an off-by-one problem. An if test skips code
for a value > 4. It should be >= 4.

The warning for a suspect logical operator was correct. With a logical or in the statement,
it made no sense.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:26:29 -05:00
..
rtw_ap.c rtl8188eu: Fix checkpatch errors in core/rtw_ap.c 2013-07-27 12:51:59 -05:00
rtw_br_ext.c rtl8188eu: Fix smatch warning in core/rtw_br_ext.c 2013-09-05 11:58:02 -05:00
rtw_cmd.c rtl8188eu: Fix smatch warnings in core/rtw_cmd.c 2013-09-05 12:03:09 -05:00
rtw_debug.c rtl8188eu: Fix checkpatch ERRORs in core/rtw_debug.c 2013-07-28 10:22:04 -05:00
rtw_efuse.c rtl8188eu: Fix smatch warnings in core/rtw_efuse.c 2013-09-05 12:08:39 -05:00
rtw_ieee80211.c rtl8188eu: Fix smatch warning in core/rtw_ieee80211.c 2013-09-05 12:10:47 -05:00
rtw_io.c rtl8188eu: Fix checkpatch errors in core/rtw_io.c 2013-07-28 19:15:57 -05:00
rtw_ioctl_set.c rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c 2013-09-05 12:26:29 -05:00
rtw_iol.c rtl8188eu: Fix checkpatch ERRORS in core/rtw_iol.c 2013-07-29 11:54:09 -05:00
rtw_led.c rtl8188eu: Fix checkpatch errors in core/rtw_led.c 2013-07-29 15:06:54 -05:00
rtw_mlme.c rtl8188eu: A few fixups 2013-08-19 12:21:40 -05:00
rtw_mlme_ext.c rtl8188eu: Fix checkpatch errors in include/*.h - part 1 2013-08-13 21:01:38 -05:00
rtw_mp.c rtl8188eu: Convert non-standard variable types to regular ones 2013-08-14 12:03:28 -05:00
rtw_mp_ioctl.c rtl8188eu: Convert non-standard variable types to regular ones 2013-08-14 12:03:28 -05:00
rtw_p2p.c rtl8188eu: Fix checkpatch errors in core/rtw_p2p.c 2013-07-31 17:26:54 -05:00
rtw_pwrctrl.c rtl8188eu: Fix checkpatch errors in core/rtw_pwrctrl.c 2013-07-31 17:27:03 -05:00
rtw_recv.c rtl8188eu: Fix bug introduced in commit ef1472a 2013-08-19 13:10:26 -05:00
rtw_rf.c rtl8188eu: Fix checkpatch errors in core/rtw_rf.c 2013-07-31 21:46:50 -05:00
rtw_security.c rtl8188eu: Convert non-standard variable types to regular ones 2013-08-14 12:03:28 -05:00
rtw_sreset.c rtl8188eu: Fix checkpatch errors in core/rtw_sreset.c 2013-08-01 13:10:46 -05:00
rtw_sta_mgt.c rtl8188eu: Fix checkpatch errors in core/rtw_sta_mgt.c 2013-08-01 13:33:20 -05:00
rtw_wlan_util.c rtl8188eu: Fix checkpatch errors in core/rtw_wlan_util.c 2013-08-02 12:12:37 -05:00
rtw_xmit.c rtl8188eu: Remove include/circ_buf.h 2013-08-15 20:09:00 -05:00