Commit graph

66 commits

Author SHA1 Message Date
Larry Finger
24b960c5c0 rtl8188eu: Change some locking around rtw_get_sec_ie()
Routine rtw_get_sec_ie() appears to suffer from a bug triggered under
unusual circumstances. This bug is exposed by first sending a deauthentication
frame and at the same time sending a much larger frame. After doing some debugging
the cause of the lockup of the CPU was that while rtw_get_sec_ie() attempts to
read the beacon frame sent by the router/AP, the size of the beacon is changed
since it is a reference and not a copy. By having a "rogue" beacon frame being
very large which isn't normal and not considered in the design, the computer
was stuck in an endless CPU lockup.

Routine translate_scan(), which calls rtw_get_sec_ie() is protected by a
spinlock. Add that spinlock around other calls of the routine.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-07-21 08:52:58 -05:00
Larry Finger
cc3c76275b Merge branch 'master' of http://github.com/lwfinger/rtl8188eu 2017-01-20 20:08:35 -06:00
Larry Finger
324b62c685 rtl8188eu: Fix a possible NUMM dereference
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-01-20 20:07:49 -06:00
Larry Finger
b3bfe784a4 rtl8188eu: Guard against pktfile crashes when skb address is NULL
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-01-16 15:37:23 -06:00
Larry Finger
e2e51bd6f4 rtl8188eu: Remove empty _rtw_free_sema()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:28:20 -06:00
Larry Finger
890e54b7a7 rtl8188eu: Remove wrapper around init_sema()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:25:08 -06:00
Larry Finger
61690cbca6 rtl8188eu: rtw_get_current_time() is jiffies
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:20:06 -06:00
Larry Finger
209e50ad60 rtlwifi: Remove list-handling macros
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:06:22 -06:00
Larry Finger
6d3d853360 rtl8188eu: Remove wrapper get_next()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 11:50:41 -06:00
Larry Finger
567257655f rtl8188eu: Replace LIST_CONTAINOR with container_of
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 10:40:44 -06:00
Larry Finger
89efde68f8 rtl8188eu: Remove wrapper around memcmp()
Caution: The wrapper inverts the state.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 09:38:17 -06:00
Larry Finger
9ad78a5b0d rtl8188eu: Remove wrapper around INIT_LIST_HEAD()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 23:13:40 -06:00
Larry Finger
545d963a9e rtl8188eu: Remove wrapper for memset()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:43:35 -06:00
Larry Finger
bad0b4cde4 rtl8188eu: Remove cases of two or more blank lines
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 18:00:05 -06:00
Larry Finger
e91077579f rtl8188eu: Remove _func_enter_ and _func_exit_ statements
Kernel tracing is more effective.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 16:31:15 -06:00
Larry Finger
849d585656 rtl8188eu: Fix some edit errors from replace spin lock wrappers
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 18:42:41 -06:00
Larry Finger
8b76b3b701 rtl8188eu: Convert spin lock macros
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 17:37:57 -06:00
Larry Finger
9fe0c17a65 rtl8188eu: Remove wrapper _rtw_spinlock_init
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 11:14:29 -06:00
Larry Finger
41245153f4 r8188eu: Fix an le16 problem
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-13 16:28:55 -06:00
Larry Finger
c2741d0bec rtl8188eu: Fix compilation for kernels older that 2.6.36
These changes will apply at least back to 2.6.32.

From: Stas Sergeev <stsp@list.ru>
Signed-off-by: Stas Sergeev <stsp@list.ru>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-02-12 11:05:30 -06:00
Larry Finger
91938194fd rtl8188eu: Make this code look exactly like the code in the kernel version
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-11-29 16:10:20 -06:00
Larry Finger
19db43ecbd rtl8188eu: Backport kernel version
This driver was added to the kernel with version 3.12. The changes in that
version are now brought back to the GitHub repo. Essentually all of the code
is updated.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 12:45:47 -05:00
Larry Finger
c2a0523bb7 rtl8188eu: Fix smatch warning in core/rtw_xmit.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1560 dequeue_one_xmitframe() info: ignoring unreachable code.

A while loop that has a break in the first pss is converted to to an if statement.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 22:11:06 -05:00
Larry Finger
96ba7d3cca rtl8188eu: Fix smatch warning in core/rtw_xmit.c
Smatch displays the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1571 dequeue_one_xmitframe() info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:25:22 -05:00
Álvaro Fernández Rojas
a7e9834fbc Remove unused variables from core files. 2013-09-06 02:44:02 +02:00
Larry Finger
7446992dc4 rtl8188eu: Remove include/circ_buf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-15 20:09:00 -05:00
Larry Finger
527bc4066f rtl8188eu: Fix checkpatch errors in core/rtw_xmit.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-02 22:16:03 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 10:56:06 -05:00
Larry Finger
4f92869c5b rtl8188eu: Remove "if 1" statements
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:37:57 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 20:08:39 -05:00
Larry Finger
476eaf9a4e rtl8188eu: Convert typedef statements from include/odm_HWConfig.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 17:56:14 -05:00
Larry Finger
3d755766c9 rtl8188eu: Convert typedef for _list to struct list_head
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-25 09:49:25 -05:00
Larry Finger
689d01adf6 rtl8188eu: Convert typedef for _queue to struct __queue
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:55:38 -05:00
Larry Finger
3e3d47445a rtl8188eu: Convert typedef for _pkt into struct sk_buff
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:03:54 -05:00
Larry Finger
2685b52404 rtl8188eu: Replace several local size defines/typedefs with kernel header version
These include the following:

SIZE_T => size_t
SSIZE_T => ssize_t
SIZE_PTR => size_t

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 12:19:14 -05:00
Larry Finger
41ad3e27c6 rtl8188eu: Convert some typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 22:39:20 -05:00
Larry Finger
dfe35fb489 rtl8188eu: Remove CONFIG_USB_VENDOR_REQ_MUTEX - not selected
This change made include/drv_conf.h and core/rtw_ioctl_query.c redundant.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 13:00:05 -05:00
Larry Finger
6667fc9990 rtl8188eu: Remove DBG_XMIT_BUF - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 16:51:34 -05:00
Larry Finger
d8627b6a67 rtl8188eu: Remove DBG_XMIT_BUF_EXT - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 16:25:28 -05:00
Larry Finger
8fcf8a9500 rtl8188eu: Remove DBG_TX_DROP_FRAME - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 16:22:15 -05:00
Larry Finger
167e245287 rtl8188eu: Remove CONFIG_LPS
This parameter is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:25:11 -05:00
Larry Finger
2f86fc26dd rtl8188eu: Remove CONFIG_XMIT_THREAD_MODE
This variable is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 17:50:08 -05:00
Larry Finger
eebbb9babd rtl8188eu: Remove CONFIG_USB_TX_AGGREGATION, IDEA_CONDITION, and CONFIG_MINIMAL_MEMORY_USAGE
CONFIG_USB_TX_AGGREGATION is always defined.
IDEA_CONDITION is always defined.
CONFIG_MINIMAL_MEMORY_USAGE is never defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-18 23:58:55 -05:00
Larry Finger
2462f06b0e rtl8188eu: Remove CONFIG_XMIT_ACK and CONFIG_XMIT_ACK_POLLING
Parameter CONFIG_XMIT_ACK is always defined, and CONFIG_XMIT_ACK_POLLING
is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-18 23:43:54 -05:00
Larry Finger
baf9862596 rtl8188eu: CONFIG_BR_EXT is always selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-18 10:42:52 -05:00
Larry Finger
acda213bd2 rtl8188eu: Remove dead code associated with WAPI
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-12 01:29:15 -05:00
Larry Finger
7c593a903d rtl8188eu: Remove dead code associated with CONFIG_CONCURRENT snd CONFIG_DUALMAC_CONCURRENT
These two configuration parameters are only associated with the RTL8192DU
device, and can be removed here.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 22:50:49 -05:00
Larry Finger
e79535e153 rtl8188eu: Remove dead code for CONFIG_TDLS
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 20:13:07 -05:00
Larry Finger
0e4009c999 rtl8188eu: Remove dead code for other than USB
The vendor code has pieces of code for PCI, SDIO, and GSPI. Remove it
and CONFIG_USB_HCI.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 13:35:36 -05:00
Larry Finger
c5e461c221 rtl8188eu: Remove configuration parameters and dead code for other devices
The vendor code includes some code that is needed for RTL8182CU, RTL8192DU,
RTL8711, RTL8712, and RTL8723AU. This dead code is removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 10:59:02 -05:00