These are already expressed as "enum rf_radio_path" and RF_PATH_x. Having
two definitions is ridiculous.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
A user has reported a stack overflow panic in this routine. This patch
removes at least 782 bytes from the stack.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
This parameter might be useful when the original driver was developed,
but it is useless in production code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse reports the following:
CHECK /home/finger/rtl8188eu/core/rtw_sta_mgt.c
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:32:6: warning: symbol '_rtw_init_stainfo' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:166:9: warning: symbol '_rtw_free_sta_xmit_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:174:6: warning: symbol 'rtw_mfree_stainfo' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse reports the following:
CHECK /home/finger/rtl8188eu/core/rtw_recv.c
/home/finger/rtl8188eu/core/rtw_recv.c:127:6: warning: symbol 'rtw_mfree_recv_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:845:6: warning: symbol 'count_rx_stats' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:1878:6: warning: symbol 'wlanhdr_to_ethhdr' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:2168:5: warning: symbol 'amsdu_to_msdu' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:2693:5: warning: symbol 'process_recv_indicatepkts' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse reports the following:
CHECK /home/finger/rtl8188eu/core/rtw_mlme_ext.c
/home/finger/rtl8188eu/core/rtw_mlme_ext.c:9446:6: warning: symbol '_linked_rx_signal_strehgth_display' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme_ext.c:8520:6: warning: context imbalance in 'start_clnt_join' - different lock contexts for basic block
The second warning was due to the failure to unlock a spin lock in a error
path.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse reports the following:
CHECK /home/finger/rtl8188eu/core/rtw_mlme.c
/home/finger/rtl8188eu/core/rtw_mlme.c💯6: warning: symbol 'rtw_mfree_mlme_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme.c:481:9: warning: symbol 'rtw_enqueue_network' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme.c:510:6: warning: symbol 'rtw_free_network' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse lists the following:
CHECK /home/finger/rtl8188eu/core/rtw_cmd.c
/home/finger/rtl8188eu/core/rtw_cmd.c:236:5: warning: symbol 'rtw_cmd_filter' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:1949:6: warning: symbol 'lps_ctrl_wk_hdl' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:2168:6: warning: symbol 'power_saving_wk_hdl' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:2744:6: warning: symbol 'rtw_getrttbl_cmd_cmdrsp_callback' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Sparse issues the following:
CHECK /home/finger/rtl8188eu/os_dep/os_intfs.c
/home/finger/rtl8188eu/os_dep/os_intfs.c:647:4: warning: symbol 'rtw_init_default_value' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
The following Sparse warnings are output:
CHECK /home/finger/rtl8188eu/os_dep/ioctl_linux.c
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3184:9: warning: context imbalance in 'rtw_get_ap_info' - different lock contexts for basic block
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3916:9: warning: context imbalance in 'rtw_p2p_get_go_device_address' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4063:9: warning: context imbalance in 'rtw_p2p_get_device_name' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4146:9: warning: context imbalance in 'rtw_p2p_get_invitation_procedure' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:6879:12: warning: context imbalance in 'rtw_del_sta' - different lock contexts for basic block
Each of these is a real error caused by improper use of a spin lock when
a spin unlock is needed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
The master branch works on PPC architecture, which is big endian; however,
v4.1.8-9499 fails to connect. Receiving is OK as scanning works, thus it is
close to working. These changes make the two branches agree on the endianess
of various header items.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
As shown in the previous commits, keeping alignment beetween the private header
and the kernel version is a problem. Solve the issue by using the kernel
version.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
To work with hostapd, the length of rtw_ieee80211_ht_cap must match
that of the kernel's ieee80211_ht_cap. Two errors were found.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
