Commit graph

135 commits

Author SHA1 Message Date
Larry Finger
242c9f54cc rtl8188eu: Fix some checkpatch warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2018-08-30 13:19:58 -05:00
Larry Finger
f8ec1962dd rtl8188eu: Remove "enum ODM_RF_RADIO_PATH" and ODM_RF_PATH_x
These are already expressed as "enum rf_radio_path" and RF_PATH_x. Having
two definitions is ridiculous.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-14 20:14:42 -06:00
Larry Finger
37a56bca8b rtl8188eu: Move arrays off stack in translate_scan()
A user has reported a stack overflow panic in this routine. This patch
removes at least 782 bytes from the stack.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-01-21 20:08:06 -06:00
Larry Finger
69faa02ea5 rtl8723bs: Remove second interface name
Only the RTL8192D chips have multiple interfaces per chip, thus
this logic has no value here.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-09-26 13:54:47 -05:00
Larry Finger
3a3339b715 rtl8188eu: Replace degub macro DBG_871X with DBG_88E
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 16:38:30 -05:00
Larry Finger
1e6accffc4 rtl8188eu: Remove wrapper routine rtw_get_current_time()
This wrapper can be replaced with jiffies.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 16:35:29 -05:00
Larry Finger
51e6fae39e rtl8188eu: Chnage "=NULL" to "= NULL"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:31:56 -05:00
Larry Finger
16d2a24227 rtl8188eu: Change "}else{" and variants to "} else {"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:27:00 -05:00
Larry Finger
0a97479cee rtl8188eu: Change "){" to ") {"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:24:16 -05:00
Larry Finger
c137ff21e5 rtl8188eu: Change "==0" to "== 0"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:22:58 -05:00
Larry Finger
9ee6ae40c3 rtl8188eu: Change "for(" to "for ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:06:32 -05:00
Larry Finger
c818db1282 rtl8188eu: Change "switch(" to "switch ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:05:44 -05:00
Larry Finger
8e22f0d2e8 rtl8188eu: Change "while(" to "while ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:04:12 -05:00
Larry Finger
6ead3e77dc rtl8188eu: Change all "if(" to "if ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:02:34 -05:00
Larry Finger
aa89a39a09 rtl8188eu: Remove spaces before quoted newline
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:00:19 -05:00
Larry Finger
c8bd30ee46 rtl8188eu: Fix Sparse errors in os_dep/ioctl_linux.c
The following Sparse warnings are output:

  CHECK   /home/finger/rtl8188eu/os_dep/ioctl_linux.c
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3184:9: warning: context imbalance in 'rtw_get_ap_info' - different lock contexts for basic block
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3916:9: warning: context imbalance in 'rtw_p2p_get_go_device_address' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4063:9: warning: context imbalance in 'rtw_p2p_get_device_name' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4146:9: warning: context imbalance in 'rtw_p2p_get_invitation_procedure' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:6879:12: warning: context imbalance in 'rtw_del_sta' - different lock contexts for basic block

Each of these is a real error caused by improper use of a spin lock when
 a spin unlock is needed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 19:35:20 -05:00
Larry Finger
b5cf1b0cf3 rtl8188eu: On kernel 2.6.32, a NULL dereference was found
This bug was reported and debugged by GitHub user jdowells.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-05-15 15:23:44 -05:00
Larry Finger
d76cbb313d rtl8188eu: Replace rtw_ieee80211_ht_cap with standard kernel version
As shown in the previous commits, keeping alignment beetween the private header
and the kernel version is a problem. Solve the issue by using the kernel
version.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-04-08 13:43:40 -05:00
Larry Finger
7460f4b22a rtl8188eu: Remove most typedef statements from include/hal_intf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-17 10:31:25 -05:00
Larry Finger
8259a22027 rtl8188eu: Remove typedef statements from include/rtw_mp_ioctl.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 20:24:53 -05:00
Larry Finger
e2285839e9 rtl8188eu: Remove most typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 08:54:18 -05:00
Larry Finger
851dc8fff5 rtl8188eu: Remove typedef statements from include/wlan_bssdef.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-14 18:14:05 -05:00
Larry Finger
e233420466 rtl8188eu: Remove executable mode for all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-13 16:54:44 -05:00
Larry Finger
2339d6c52a rtl8188eu: Remove DBG_CONFIG_ERROR_DETECT
This symbol is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-11 20:21:04 -05:00
Larry Finger
993b4435cb rtl8188eu: Fix most errors from smatch
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-10 11:18:03 -05:00
Larry Finger
464dd388cf rtl8188eu: Remove CONFIG_PLATFORM_MT53XX
This is not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-07 13:10:07 -06:00
Larry Finger
10a995af18 rtl8188eu: Remove RTK_DMP_PLATFORM
This is not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-07 13:07:38 -06:00
Larry Finger
49de871812 rtl8188eu: Remove CONFIG_PLATFORM_ROCKCHIPS
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-06 19:00:36 -06:00
Larry Finger
3b93a7822a rtl8188eu: Remove CONFIG_SIGNAL_DISPLAY_DBM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-06 18:58:36 -06:00
Larry Finger
4bf02bb7d8 rtl8188eu: Replace typedef for WLAN_BSSID_EX
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-06 18:26:23 -06:00
Larry Finger
5d615fab61 rtl8188eu: Rename get_WLAN_BSSID_EX_sz
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-06 18:01:31 -06:00
Larry Finger
c0ef452bab rtl8188eu: Remove wrappers around spin_lock_bh and spin_unlock_bh
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-06 11:55:51 -06:00
Larry Finger
1bb0401638 rtl8188eu: CONFIG_TDLS
This variable is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-04 15:31:57 -06:00
Larry Finger
dd62caa1e1 rtl8199eu: Replace TRUE and FALSE with true and false
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 17:25:27 -06:00
Larry Finger
ed192682fe rtl_8188eu: Remove CONFIG_MMC_PM_KEEP_POWER, and CONFIG_WOWLAN
These parameters are not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 17:03:18 -06:00
Larry Finger
4b61fd5bf7 rtl8188eu: Remove CONFIG_WAPI_SUPPORT
This symbol is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 11:12:58 -06:00
Larry Finger
1d52d1060a rtl8188eu: Remove CONFIG_INTEL_WIDI
This symbol was not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 10:54:45 -06:00
Larry Finger
e5f09bb52b rtl8188eu: Remove CONFIG_GLOBAL_UI_PID
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 10:35:25 -06:00
Larry Finger
27f745af7b rtl8188eu: Remove some configuration variables defined when CONFIG_P2P is defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 22:48:40 -06:00
Larry Finger
1155811fcf rtl8188eu: Remove CONFIG_IOL
This parameter is defined by default.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 10:36:23 -06:00
Larry Finger
427ab12050 rtl8188eu: Remove CONFIG_IOL_NEW_GENERATION
This one is selected by defining CONFIG_IOL.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-28 16:12:47 -06:00
Larry Finger
fdafd36b5e rtl8188eu: Clean up os_dep/ioctl_linux.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-26 12:18:57 -06:00
Larry Finger
dae15933ce rtl8188eu: Remove CONFIG_LPS
This symbol is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 20:32:00 -06:00
Larry Finger
7f75913cfb rtl8188eu: Remove CONFIG_IPS
This one is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:18:56 -06:00
Larry Finger
2b27b83d40 rtl8188eu: Remove CONFIG_80211N_HT
This one is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 20:30:23 -06:00
Larry Finger
5470a10d13 rtl8188eu: Remove CONFIG_IOCTL_CFG80211
This one is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 22:52:01 -06:00
Larry Finger
34c3293686 rtl8188eu: Convert C90 comments in os_dep
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 22:11:26 -06:00
Larry Finger
9b5b5c4e12 rtl8188eu: Replace wrapper for memset
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 14:58:09 -06:00
Larry Finger
529328fd3d rtl8188eu: Replace wrapper for memcpy
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 14:50:04 -06:00
Larry Finger
276a62340a rtl8188eu: Fix more endian issues
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-16 13:00:49 -06:00