Commit graph

827 commits

Author SHA1 Message Date
Larry Finger
573b2f4e6e rtl8188eu: Address warning in createbss_hdl()
The code issues a warning as follows:

[ 817.111258] WARNING: CPU: 5 PID: 772 at createbss_hdl+0x120/0x148 [8188eu]
[ 817.111502] Modules linked in: 8188eu(O) cfg80211 lib80211 [last unloaded: 8188eu]
[ 817.111520] CPU: 5 PID: 772 Comm: RTW_CMD_THREAD Tainted: G WC O 5.10.145-rt74+g1594b25154a2 #1
[ 817.111527] Hardware name: NXP S32G399A-RDB3 (DT)
[ 817.111531] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--)
[ 817.111537] pc : createbss_hdl+0x120/0x148 [8188eu]
[ 817.111672] lr : rtw_cmd_thread+0x454/0x548 [8188eu]
[ 817.111806] sp : ffffffc013db3da0
[ 817.111808] x29: ffffffc013db3da0 x28: ffffffc0089c9168
[ 817.111815] x27: ffffffc008909f74 x26: 0000000000001400
[ 817.111821] x25: ffffffc0089c90f8 x24: ffffffc011010320
[ 817.111827] x23: ffffffc011010400 x22: 000000010001f8f3
[ 817.111833] x21: ffffffc011010350 x20: ffffffc01100f000
[ 817.111839] x19: ffffffc01100f000 x18: 0000000000000000
[ 817.111845] x17: 0000000000000001 x16: 0000000000000000
[ 817.111851] x15: 001fffffffffffff x14: 00000000001d7000
[ 817.111857] x13: 0000000000000370 x12: 0000000000000000
[ 817.111863] x11: 0000000000000370 x10: 00000000000008e0
[ 817.111868] x9 : ffffffc013db3960 x8 : ffffff880230eb00
[ 817.111874] x7 : 0000000000000001 x6 : ffffff8804ea9206
[ 817.111880] x5 : 0000800020000000 x4 : 0000000000000000
[ 817.111886] x3 : 000000000000ffff x2 : 0000000000000006
[ 817.111893] x1 : ffffff8804ea9200 x0 : 0000000000000000
[ 817.111900] Call trace:
[ 817.111903] createbss_hdl+0x120/0x148 [8188eu]
[ 817.112037] rtw_cmd_thread+0x454/0x548 [8188eu]
[ 817.112170] kthread+0x178/0x180
[ 817.112184] ret_from_fork+0x10/0x30
[ 817.112193] ---[ end trace 00f853683c01e7a3 ]---

My investigation shows that the test for an invalid length was placed after
the memcpy() call that generates this warning.

The fix is to move the test above the memcpy, and to increase the maximum
size of the IE buffer.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-06-30 11:28:23 -05:00
Larry Finger
f435a10625 rtl8188eu: Remove useless warning
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-04-10 15:40:15 -05:00
Larry Finger
b5d64670e9 rtl8188eu: Prevent crash when ssids is NULL
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-04-10 12:23:27 -05:00
Larry Finger
57bd21c563 rtl8188eu: Possible fix for iwd crash
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-04-09 12:54:37 -05:00
Larry Finger
1201a7a51f rtl8188eu: Apply "fix" suggested by user
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-02-18 12:56:39 -06:00
Larry Finger
51051d2e4b rtl8188eu: Add hardware LED blanking
See https://github.com/lwfinger/rtl8188eu/issues/342 for discussion.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-12-20 17:24:21 -06:00
lwfinger
f4af53305c
Merge pull request #433 from giuliobenetti/fix/powerpc-leftover
rtl8188eu: convert left-over get_ra() to wifi_get_ra()
2022-11-28 20:04:04 -06:00
Giulio Benetti
b9637c592b rtl8188eu: convert left-over get_ra() to wifi_get_ra()
During commit 7245a6982d one occurence of
get_ra() has been left behind in ioctl_cfg80211.c so let's update it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
2022-11-29 00:45:23 +01:00
Larry Finger
7245a6982d rtl8188eu: Change get_ra() to wifi_get_ra()
Author: Giulio Benetti giulio.benetti@benettiengineering.com

In PowerPc Linux only get_ra() exists[0] and conflicts with local get_ra()
that has a completely different purpose. So let's rename local get_ra()
to wifi_get_ra() to make it different from Linux's get_ra().

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm/disassemble.h?h=v6.1-rc7#n49

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-11-28 15:26:05 -06:00
Larry Finger
208f2ccb65 rtl8188eu: Fix build for kernel 6.1
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-11-28 13:29:37 -06:00
Larry Finger
f99f244be3 rtl8188eu: Fix build on kernel 6.1
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-11-28 12:48:18 -06:00
lwfinger
c4908ca4ca
Merge pull request #427 from giuliobenetti/fix/linux-before-6.0.0
Re-introduce code for Linux version < 6.0.0.
2022-10-17 18:30:31 -05:00
Giulio Benetti
ca95522030 Re-introduce code for Linux version < 6.0.0.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
2022-10-17 23:18:37 +02:00
lwfinger
77c1b083c5
Merge pull request #426 from CoelacanthusHex/fix/v5/riscv
rtl8188eu: fix SUBARCH on riscv64
2022-10-11 10:31:10 -05:00
Celeste Liu
fd6c97ef99
rtl8188eu: fix SUBARCH on riscv64
Signed-off-by: Celeste Liu <CoelacanthusHex@gmail.com>
2022-10-11 22:54:45 +08:00
Larry Finger
7c6e80da34 rtl8188eu: Remove wrapper around spin_unlock_irqrestore()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-09-14 12:31:35 -05:00
Larry Finger
8f5cee5861 rtl8188eu: Change definition of KSRC in Makefile
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-29 10:04:39 -05:00
Larry Finger
e488450b36 rtl8188eu: Remove code not needed for kernel 60.0
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-27 12:08:47 -05:00
Larry Finger
e79b15cb79 rtl8188eu: Change location for saved module
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-27 12:06:53 -05:00
Larry Finger
7a7c5e0c0b rtl8188eu: Revert one of the changes for 5.19.2
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-18 16:00:27 -05:00
Larry Finger
96c88129ba rtl8188eu: Fix builds for kernel 5.19.2
The changes that were in kernel 6.0 hav been backported to 5.19.2.
Backporting these kind of changes is pointless. In 6.0, the way is
prepared to allow multiple links per connection. In 5.19, the only
one used is link 0! What is the point?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-18 10:45:53 -05:00
Larry Finger
0a5e81555c rtl8188eu: Fix builds for kernel 6.0
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-08-12 12:11:45 -05:00
Larry Finger
318a5f1d15 rtl8188eu: Fill out set/get txpower
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-07-16 13:21:15 -05:00
Larry Finger
a36cfdfdb6 rtl8188eu: Fix some gcc12 compiler warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-07-15 13:51:36 -05:00
Larry Finger
903b6fcb82 rtl8188eu: Add hostapd-2.9 modified for the rtl871x driver
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-04-17 13:00:45 -05:00
Larry Finger
13531f3844 rtl8188eu: Fix build for kernel 5.18
Also update control_ap

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-04-17 12:49:39 -05:00
Larry Finger
bf23ec4903 rtl8188eu: Fix another API change for kernel 5.17
Struct net_device has been constantified, thus it is no longer OK to
drirectly write the dev_addr, but use dev_addr_set() instead. Starting
with kernel 5.17, improper usage generates a warning.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-28 20:49:20 -06:00
Larry Finger
5b67bc47ea rtl8188eu: Fix bug related to removal of GRO_DROP
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-26 13:11:39 -06:00
Larry Finger
9d070c63c5 rtl8188eu: Remove CONFIG_IOCTL_CFG80211 from autoconf.h
This configuration option is now set in Makefile.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
_
2022-01-26 13:10:04 -06:00
Larry Finger
1944ad78ce rtl8188eu: Fix build with kernel 5.17
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-26 13:07:47 -06:00
Larry Finger
78df4f193d rtl8188eu: Add CONFIG_IOCTL_CFG80211 to Makefile
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-25 00:47:17 -06:00
Larry Finger
7ba3df1bcb rtl8188eu: Fix lockup on start
Kernel commit 51d62f2f2c50 ("cfg80211: Save the regulatory domain with a lock")
caused a lock dependency to the cfg80211 version of this driver. It is fixed by
moving the regulatory domain initialization call so that it is outside the lock
in the probe routine.

See https://github.com/lwfinger/rtl8188eu/issues/386 for further discussion.
Signed-off-by: Georg Mueller
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-15 11:42:34 -06:00
Larry Finger
a2c8a1deda rtl8188eu: Remove dead code associated with CONFIG_PLATFORM_INTEL_BYT
This variable is never defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-14 21:17:17 -06:00
Larry Finger
53ed527078 rtl8188eu: Fix Makefile to create directory for module
If a kernel is being used that generates no drivers in the
/lib/modules/$(KVER)/kernel/drivers/net/wireless directory, the installation
will fail. The fix is to generate that directory if it is not present.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-01-10 13:06:20 -06:00
Larry Finger
a1dbe3155c rtl8188eu: Fix build for kernel 5.15
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-10-18 16:13:42 -05:00
Larry Finger
99a65acdfc rtl8188eu: Simplify Makefile
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 19:45:13 -05:00
Larry Finger
5e6ddcda98 rtl8188eu: Flatten include/
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 19:37:03 -05:00
Larry Finger
43a72191f6 rtl8188eu: Flatten os_dep
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 19:19:25 -05:00
Larry Finger
e086df9ed1 rtl8188eu: Ftatten btc
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 19:04:09 -05:00
Larry Finger
4de1397841 rtl8188eu: Flatten hap/
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 18:57:16 -05:00
Larry Finger
81aeb84017 rtl8188eu: Flatten core
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 18:34:17 -05:00
Larry Finger
2e52830997 rtl8188eu: Flatten hal directory
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-07-22 12:55:23 -05:00
Larry Finger
07152ef10d rtl8188eu: Use CONFIG_PREEMPT_RT to select raw spin lock form for real-time kernels
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-23 19:32:46 -05:00
Larry Finger
6c792da5b8 rtl8188eu: Change locking in update_sta_info
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-23 10:33:18 -05:00
Larry Finger
d124526cf3 rtl8188eu: Another fix for RTL8188FU
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-20 13:17:43 -05:00
Larry Finger
fe4156ba5a rtl8188eu: Add RTL8188F support
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-20 13:05:41 -05:00
Larry Finger
8cb717bd63 rtl8188eu: Update some fixes
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-19 10:11:34 -05:00
Larry Finger
6d74135f34 rtl8188eu: Further cleanup of Makefile
Symbol CONFIG_RTL8188EU is only used in one place. Replace that usage with "m" and
delete the definition.

Symbol CONFIG_USB_HCI is not used. Delete it.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-04 13:00:47 -06:00
lwfinger
c1c7ce88cb
Merge pull request #364 from ukleinek/makefile-cleanup
Makefile cleanup
2021-03-04 12:55:16 -06:00
Uwe Kleine-König
6533925f01 rtl8188eu: Use make builtin variable CURDIR
This variable holds the current working directory and so is suitable to
be used instead of $(shell pwd).
2021-03-04 14:35:46 +01:00