Commit graph

44 commits

Author SHA1 Message Date
Larry Finger
24b960c5c0 rtl8188eu: Change some locking around rtw_get_sec_ie()
Routine rtw_get_sec_ie() appears to suffer from a bug triggered under
unusual circumstances. This bug is exposed by first sending a deauthentication
frame and at the same time sending a much larger frame. After doing some debugging
the cause of the lockup of the CPU was that while rtw_get_sec_ie() attempts to
read the beacon frame sent by the router/AP, the size of the beacon is changed
since it is a reference and not a copy. By having a "rogue" beacon frame being
very large which isn't normal and not considered in the design, the computer
was stuck in an endless CPU lockup.

Routine translate_scan(), which calls rtw_get_sec_ie() is protected by a
spinlock. Add that spinlock around other calls of the routine.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2022-07-21 08:52:58 -05:00
Larry Finger
8eb572bc42 rtl8188eu: Replace rtw_ieee80211_ht_cap with standard kernel version
As shown in the previous commits, keeping alignment beetween the private header
and the kernel version is a problem. Solve the issue by using the kernel
version.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-04-08 14:02:06 -05:00
Larry Finger
f760caeb39 rtl8188eu: Add test for memory allocation failure
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-26 11:01:33 -06:00
Larry Finger
89efde68f8 rtl8188eu: Remove wrapper around memcmp()
Caution: The wrapper inverts the state.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 09:38:17 -06:00
Larry Finger
545d963a9e rtl8188eu: Remove wrapper for memset()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:43:35 -06:00
Larry Finger
ed2c3ab733 rtl8188eu: Rework endianess
Several of the struct items related to on-air data must be little endian.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 12:15:07 -06:00
Larry Finger
bad0b4cde4 rtl8188eu: Remove cases of two or more blank lines
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 18:00:05 -06:00
Larry Finger
e91077579f rtl8188eu: Remove _func_enter_ and _func_exit_ statements
Kernel tracing is more effective.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 16:31:15 -06:00
Larry Finger
91938194fd rtl8188eu: Make this code look exactly like the code in the kernel version
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-11-29 16:10:20 -06:00
Larry Finger
19db43ecbd rtl8188eu: Backport kernel version
This driver was added to the kernel with version 3.12. The changes in that
version are now brought back to the GitHub repo. Essentually all of the code
is updated.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 12:45:47 -05:00
Larry Finger
3be2cff4fe rtl8188eu: Fix smatch warning in core/rtw_wlan_util.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_wlan_util.c
/home/finger/rtl8188eu/core/rtw_wlan_util.c:1111 rtw_check_bcn_info() info: ignoring unreachable code.

This case had the _func_exit_ macro after a return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:22:23 -05:00
Álvaro Fernández Rojas
bf4d305a09 Fix duplicated use of BROADCOM_OUI2, leaving BROADCOM_OUI3 unused. 2013-09-06 02:45:38 +02:00
Álvaro Fernández Rojas
a7e9834fbc Remove unused variables from core files. 2013-09-06 02:44:02 +02:00
Larry Finger
7b59aa12db rtl8188eu: Fix checkpatch errors in core/rtw_wlan_util.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-02 12:12:37 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 10:56:06 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 20:08:39 -05:00
Larry Finger
ec5245f648 rtl8188eu: Convert typedef statements in include/rtw_rf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 16:27:19 -05:00
Larry Finger
a01908ab27 rtl8188eu: Convert the typedef statements in include/wlan_bssdef.h
One remains that I still do not know how to convert; however, it has been
moved to os_dep/ioctl_linux.c where it is used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 21:31:04 -05:00
Larry Finger
dfe35fb489 rtl8188eu: Remove CONFIG_USB_VENDOR_REQ_MUTEX - not selected
This change made include/drv_conf.h and core/rtw_ioctl_query.c redundant.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 13:00:05 -05:00
Larry Finger
c7c446f21a rtl8188eu: Remove CONFIG_DFS - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 16:58:15 -05:00
Larry Finger
39f4cd8546 rtl8188eu: Remove CONFIG_WFD - not selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 13:53:07 -05:00
Larry Finger
9799b069cb rtl8188eu: Remove RTL8192C_RECONFIG_TO_1T1R
This symbol is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 22:15:17 -05:00
Larry Finger
387ba28bf9 rtl8188eu: Remove CONFIG_DISABLE_MCS13TO15
This variable is not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 16:41:41 -05:00
Larry Finger
55d4e504a2 rtl8188eu: Remove CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ
This variable is not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 16:38:21 -05:00
Larry Finger
6583d55cd1 rtl8188eu: Remove dead code associated with CONFIG_INTEL_XXX
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-12 20:51:15 -05:00
Larry Finger
7c593a903d rtl8188eu: Remove dead code associated with CONFIG_CONCURRENT snd CONFIG_DUALMAC_CONCURRENT
These two configuration parameters are only associated with the RTL8192DU
device, and can be removed here.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 22:50:49 -05:00
Larry Finger
e79535e153 rtl8188eu: Remove dead code for CONFIG_TDLS
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 20:13:07 -05:00
Larry Finger
d2c90ee304 rtl8188eu: Change C90 comments to kernel form for files in core/
This commit also includes some sparse fixes for endian issues.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-09 17:38:46 -05:00
Larry Finger
fb786d0283 rtl8188eu: Fix all W=1 warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-21 13:41:29 -05:00
Larry Finger
5c8ff88003 rtl8192eu: Fix more sparse errors
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-20 10:13:14 -05:00
Larry Finger
327817d32a rtl8188eu: Fix most sparse warnings other than endedness problems
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-03 14:52:18 -05:00
Larry Finger
925510ff1a rtl8188eu: Change all MAC_FMT to %pM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-30 15:51:53 -05:00
Larry Finger
78adabf36d rtl8188eu: Remove unused IN and OUT directives used only for Windows
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-26 22:51:56 -05:00
Larry Finger
9cef34aa09 rtl8188eu: Change _FALSE and _TRUE to false and true
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 22:02:10 -05:00
Larry Finger
96adb823b9 rtl8188eu: Update logging
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 18:35:42 -05:00
Larry Finger
d597e07a9e rtl8188eu: More cleanups of code
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 15:45:50 -05:00
Larry Finger
3535ad59e3 rtl8188eu: Change BOOLEAN to bool
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 23:48:10 -05:00
Larry Finger
f5f3863bc5 rtl8188eu: Remove trailing white space from all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 23:28:07 -05:00
Larry Finger
77e736c66a rtl8188eu: Remove dead code inside #if 0 ... #endif
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 16:16:10 -05:00
Larry Finger
d4fa4d178f Replace __FUNCTION__ with __func__
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-09 11:23:32 -05:00
Larry Finger
4620c2a956 Remove the execute privilege bit on all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:36:05 -05:00
Larry Finger
d25660e511 Remove space before \n in formats
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:09:18 -05:00
Larry Finger
a55f866a62 Change "if(" to "if (" and the same changes for "while", "for", "switch" and "do"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:04:25 -05:00
Larry Finger
85df502f5b Initial commit of flattened driver to repo
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 16:45:39 -05:00