Larry Finger
bb55393afa
rtl8188eu: Fix NULL pointer
...
User hlguo reports crashes due to a NULL pointer dereference. This should fix it.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-22 22:13:56 -06:00
Larry Finger
e2e51bd6f4
rtl8188eu: Remove empty _rtw_free_sema()
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:28:20 -06:00
Larry Finger
890e54b7a7
rtl8188eu: Remove wrapper around init_sema()
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:25:08 -06:00
Larry Finger
61690cbca6
rtl8188eu: rtw_get_current_time() is jiffies
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:20:06 -06:00
Larry Finger
209e50ad60
rtlwifi: Remove list-handling macros
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:06:22 -06:00
Larry Finger
6d3d853360
rtl8188eu: Remove wrapper get_next()
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 11:50:41 -06:00
Larry Finger
567257655f
rtl8188eu: Replace LIST_CONTAINOR with container_of
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 10:40:44 -06:00
Larry Finger
7fd86158bf
rtl8188eu: Change union recv_frame to struct
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 10:35:48 -06:00
Larry Finger
89efde68f8
rtl8188eu: Remove wrapper around memcmp()
...
Caution: The wrapper inverts the state.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 09:38:17 -06:00
Larry Finger
24391e61f4
rtl8188eu: Remove wrapper around some kzalloc() calls
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 09:08:01 -06:00
Larry Finger
9ad78a5b0d
rtl8188eu: Remove wrapper around INIT_LIST_HEAD()
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 23:13:40 -06:00
Larry Finger
609fff0d67
rtl8188eu: Remove wrapper around semaphore 'up'
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:51:56 -06:00
Larry Finger
545d963a9e
rtl8188eu: Remove wrapper for memset()
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:43:35 -06:00
Larry Finger
4e305e82d0
rtl8188eu: Rework handling of BA_para_set
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:32:07 -06:00
Larry Finger
26930b0f9f
rtl8188eu: Replace RTW_PUT_LE16
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:30:01 -06:00
Larry Finger
6ba33b6e48
rtl8188eu: Remove macro RTW_GET_LE16
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 21:55:10 -06:00
Larry Finger
d6aed151f2
rtl8188eu: Simplify handling of LE variables
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 21:50:54 -06:00
Larry Finger
ed2c3ab733
rtl8188eu: Rework endianess
...
Several of the struct items related to on-air data must be little endian.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 12:15:07 -06:00
Larry Finger
bad0b4cde4
rtl8188eu: Remove cases of two or more blank lines
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 18:00:05 -06:00
Larry Finger
e91077579f
rtl8188eu: Remove _func_enter_ and _func_exit_ statements
...
Kernel tracing is more effective.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 16:31:15 -06:00
Larry Finger
849d585656
rtl8188eu: Fix some edit errors from replace spin lock wrappers
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 18:42:41 -06:00
Larry Finger
8b76b3b701
rtl8188eu: Convert spin lock macros
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 17:37:57 -06:00
Larry Finger
9fe0c17a65
rtl8188eu: Remove wrapper _rtw_spinlock_init
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 11:14:29 -06:00
Larry Finger
287f6491f3
rtl8188eu: Part 3 of the upgrades from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-20 00:12:27 -06:00
Larry Finger
ef77969222
rtl8188eu: More changes from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
...
This one completes the changes for rtw_mlme.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-19 18:03:11 -06:00
Larry Finger
c8a380cd16
rtl8188eu: Make updates from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
...
This patch is step 1 of many. This driver has much better sensitivity than
the previous version.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-19 14:32:12 -06:00
Larry Finger
41245153f4
r8188eu: Fix an le16 problem
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-13 16:28:55 -06:00
Larry Finger
c2741d0bec
rtl8188eu: Fix compilation for kernels older that 2.6.36
...
These changes will apply at least back to 2.6.32.
From: Stas Sergeev <stsp@list.ru>
Signed-off-by: Stas Sergeev <stsp@list.ru>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-02-12 11:05:30 -06:00
Larry Finger
295bb23ffe
rtl8188eu: Fix reporting of signal strength and quality
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-12-30 21:18:17 -06:00
Larry Finger
91938194fd
rtl8188eu: Make this code look exactly like the code in the kernel version
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-11-29 16:10:20 -06:00
Larry Finger
19db43ecbd
rtl8188eu: Backport kernel version
...
This driver was added to the kernel with version 3.12. The changes in that
version are now brought back to the GitHub repo. Essentually all of the code
is updated.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 12:45:47 -05:00
Larry Finger
3695d581c6
rtl8188eu: Fix AP problem introduced in commit 954eab3
...
Two code lines were accidentally deleted in the commit noted in subject.
Restore them.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-27 12:46:29 -05:00
Larry Finger
66ccf88866
rtl8188eu: Fix smatch warnings in core/rtw_security.c
...
Smatch shows the following:
CHECK /home/finger/rtl8188eu/core/rtw_security.c
/home/finger/rtl8188eu/core/rtw_security.c:2077 rijndaelKeySetupEnc() warn: '4' 4 can't fit into 4611686018427387903 'rk'
/home/finger/rtl8188eu/core/rtw_security.c:2108 rijndaelEncrypt() warn: '8' 8 can't fit into 4611686018427387903 'rk'
These warnings were fixed by removing a number of unused routines.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 23:09:00 -05:00
Larry Finger
c2a0523bb7
rtl8188eu: Fix smatch warning in core/rtw_xmit.c
...
Smatch shows the following:
CHECK /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1560 dequeue_one_xmitframe() info: ignoring unreachable code.
A while loop that has a break in the first pss is converted to to an if statement.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 22:11:06 -05:00
Larry Finger
aa4ccbe53f
rtl8188eu: Remove unused static data defines from core/rtw_recv.c
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 10:04:31 -05:00
Larry Finger
9580338a0b
Merge branch 'next' of https://github.com/Noltari/rtl8188eu
2013-09-06 09:59:30 -05:00
Álvaro Fernández Rojas
27670d56d0
Move vars from rtw_recv.h to rtw_recv.c in order to prevent unused vars warnings when including rtw_recv.h.
...
Note that SNAP_ETH_TYPE_APPLETALK_DDP, SNAP_ETH_TYPE_TDLS, SNAP_HDR_APPLETALK_DDP, oui_8021h and oui_rfc1042 are still unused and can be commented out.
2013-09-06 12:09:58 +02:00
Larry Finger
96ba7d3cca
rtl8188eu: Fix smatch warning in core/rtw_xmit.c
...
Smatch displays the following:
CHECK /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1571 dequeue_one_xmitframe() info: ignoring unreachable code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:25:22 -05:00
Larry Finger
3be2cff4fe
rtl8188eu: Fix smatch warning in core/rtw_wlan_util.c
...
Smatch shows the following:
CHECK /home/finger/rtl8188eu/core/rtw_wlan_util.c
/home/finger/rtl8188eu/core/rtw_wlan_util.c:1111 rtw_check_bcn_info() info: ignoring unreachable code.
This case had the _func_exit_ macro after a return.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:22:23 -05:00
Álvaro Fernández Rojas
bf4d305a09
Fix duplicated use of BROADCOM_OUI2, leaving BROADCOM_OUI3 unused.
2013-09-06 02:45:38 +02:00
Álvaro Fernández Rojas
a7e9834fbc
Remove unused variables from core files.
2013-09-06 02:44:02 +02:00
Larry Finger
65c4e60be3
rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c
...
Smatch reports the following problems:
CHECK /home/finger/rtl8188eu/core/rtw_ioctl_set.c
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:593 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:595 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:745 rtw_set_802_11_add_key() warn: was && intended here instead of ||?
The buffer overflow messages are due to an off-by-one problem. An if test skips code
for a value > 4. It should be >= 4.
The warning for a suspect logical operator was correct. With a logical or in the statement,
it made no sense.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:26:29 -05:00
Larry Finger
d1d8ed064b
rtl8188eu: Fix smatch warning in core/rtw_ieee80211.c
...
Smatch reports the following warning:
CHECK /home/finger/rtl8188eu/core/rtw_ieee80211.c
/home/finger/rtl8188eu/core/rtw_ieee80211.c:161 rtw_set_ie() info: ignoring unreachable code.
This warning is caused by a _func_exit_ macro placed after the return.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:10:47 -05:00
Larry Finger
8f7fde8d6a
rtl8188eu: Fix smatch warnings in core/rtw_efuse.c
...
Smatch reports the following warnings:
CHECK /home/finger/rtl8188eu/core/rtw_efuse.c
/home/finger/rtl8188eu/core/rtw_efuse.c:646 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:655 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:738 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:747 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
These are due to an off-by-one error in an array size.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:08:39 -05:00
Larry Finger
4769256ac2
rtl8188eu: Fix smatch warnings in core/rtw_cmd.c
...
Smatch reports the following warnings:
CHECK /home/finger/rtl8188eu/core/rtw_cmd.c
/home/finger/rtl8188eu/core/rtw_cmd.c:385 rtw_cmd_thread() error: buffer overflow 'wlancmds' 63 <= 63
/home/finger/rtl8188eu/core/rtw_cmd.c:403 rtw_cmd_thread() error: buffer overflow 'rtw_cmd_callback' 63 <= 63
These are caused by an off-by-one error using <= rather than <.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:03:09 -05:00
Larry Finger
ccd4c72b62
rtl8188eu: Fix smatch warning in core/rtw_br_ext.c
...
Smatch reports the following warning:
CHECK /home/finger/rtl8188eu/core/rtw_br_ext.c
/home/finger/rtl8188eu/core/rtw_br_ext.c:693 nat25_db_handle() info: ignoring unreachable code.
Remove an entra return statement.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 11:58:02 -05:00
Larry Finger
993b021502
rtl8188eu: Fix bug introduced in commit ef1472a
...
The bug caused failure to transfter data for any B/G network.
Reported by Paolo Valleri
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-19 13:10:26 -05:00
Larry Finger
0306cad214
rtl8188eu: A few fixups
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-19 12:21:40 -05:00
Larry Finger
7446992dc4
rtl8188eu: Remove include/circ_buf.h
...
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-15 20:09:00 -05:00
Larry Finger
2db42a3fbf
rtl8188eu: Convert non-standard variable types to regular ones
...
These include changing s1Byte to s8, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-14 12:03:28 -05:00