skyfall/rtl8188eu
1
0
Fork 0
mirror of https://github.com/lwfinger/rtl8188eu.git synced 2024-11-25 05:53:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
350 commits 6 branches 0 tags 24 MiB
Commit graph

191 commits

Author SHA1 Message Date
Larry Finger
66ccf88866 rtl8188eu: Fix smatch warnings in core/rtw_security.c 
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_security.c
/home/finger/rtl8188eu/core/rtw_security.c:2077 rijndaelKeySetupEnc() warn: '4' 4 can't fit into 4611686018427387903 'rk'
/home/finger/rtl8188eu/core/rtw_security.c:2108 rijndaelEncrypt() warn: '8' 8 can't fit into 4611686018427387903 'rk'

These warnings were fixed by removing a number of unused routines.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-06 23:09:00 -05:00
Larry Finger
c2a0523bb7 rtl8188eu: Fix smatch warning in core/rtw_xmit.c 
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1560 dequeue_one_xmitframe() info: ignoring unreachable code.

A while loop that has a break in the first pss is converted to to an if statement.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-06 22:11:06 -05:00
Larry Finger
aa4ccbe53f rtl8188eu: Remove unused static data defines from core/rtw_recv.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-06 10:04:31 -05:00
Larry Finger
9580338a0b Merge branch 'next' of https://github.com/Noltari/rtl8188eu 2013-09-06 09:59:30 -05:00
Álvaro Fernández Rojas
27670d56d0 Move vars from rtw_recv.h to rtw_recv.c in order to prevent unused vars warnings when including rtw_recv.h. 
Note that SNAP_ETH_TYPE_APPLETALK_DDP, SNAP_ETH_TYPE_TDLS, SNAP_HDR_APPLETALK_DDP, oui_8021h and oui_rfc1042 are still unused and can be commented out.
 2013-09-06 12:09:58 +02:00
Larry Finger
96ba7d3cca rtl8188eu: Fix smatch warning in core/rtw_xmit.c 
Smatch displays the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1571 dequeue_one_xmitframe() info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 22:25:22 -05:00
Larry Finger
3be2cff4fe rtl8188eu: Fix smatch warning in core/rtw_wlan_util.c 
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_wlan_util.c
/home/finger/rtl8188eu/core/rtw_wlan_util.c:1111 rtw_check_bcn_info() info: ignoring unreachable code.

This case had the _func_exit_ macro after a return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 22:22:23 -05:00
Álvaro Fernández Rojas
bf4d305a09 Fix duplicated use of BROADCOM_OUI2, leaving BROADCOM_OUI3 unused. 2013-09-06 02:45:38 +02:00
Álvaro Fernández Rojas
a7e9834fbc Remove unused variables from core files. 2013-09-06 02:44:02 +02:00
Larry Finger
65c4e60be3 rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c 
Smatch reports the following problems:
  CHECK   /home/finger/rtl8188eu/core/rtw_ioctl_set.c
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:593 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:595 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:745 rtw_set_802_11_add_key() warn: was && intended here instead of ||?

The buffer overflow messages are due to an off-by-one problem. An if test skips code
for a value > 4. It should be >= 4.

The warning for a suspect logical operator was correct. With a logical or in the statement,
it made no sense.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 12:26:29 -05:00
Larry Finger
d1d8ed064b rtl8188eu: Fix smatch warning in core/rtw_ieee80211.c 
Smatch reports the following warning:
  CHECK   /home/finger/rtl8188eu/core/rtw_ieee80211.c
/home/finger/rtl8188eu/core/rtw_ieee80211.c:161 rtw_set_ie() info: ignoring unreachable code.

This warning is caused by a _func_exit_ macro placed after the return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 12:10:47 -05:00
Larry Finger
8f7fde8d6a rtl8188eu: Fix smatch warnings in core/rtw_efuse.c 
Smatch reports the following warnings:

  CHECK   /home/finger/rtl8188eu/core/rtw_efuse.c
/home/finger/rtl8188eu/core/rtw_efuse.c:646 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:655 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:738 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:747 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8

These are due to an off-by-one error in an array size.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 12:08:39 -05:00
Larry Finger
4769256ac2 rtl8188eu: Fix smatch warnings in core/rtw_cmd.c 
Smatch reports the following warnings:
  CHECK   /home/finger/rtl8188eu/core/rtw_cmd.c
/home/finger/rtl8188eu/core/rtw_cmd.c:385 rtw_cmd_thread() error: buffer overflow 'wlancmds' 63 <= 63
/home/finger/rtl8188eu/core/rtw_cmd.c:403 rtw_cmd_thread() error: buffer overflow 'rtw_cmd_callback' 63 <= 63

These are caused by an off-by-one error using <= rather than <.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 12:03:09 -05:00
Larry Finger
ccd4c72b62 rtl8188eu: Fix smatch warning in core/rtw_br_ext.c 
Smatch reports the following warning:
  CHECK   /home/finger/rtl8188eu/core/rtw_br_ext.c
/home/finger/rtl8188eu/core/rtw_br_ext.c:693 nat25_db_handle() info: ignoring unreachable code.

Remove an entra return statement.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-09-05 11:58:02 -05:00
Larry Finger
993b021502 rtl8188eu: Fix bug introduced in commit ef1472a 
The bug caused failure to transfter data for any B/G network.

Reported by Paolo Valleri
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-19 13:10:26 -05:00
Larry Finger
0306cad214 rtl8188eu: A few fixups 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-19 12:21:40 -05:00
Larry Finger
7446992dc4 rtl8188eu: Remove include/circ_buf.h 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-15 20:09:00 -05:00
Larry Finger
2db42a3fbf rtl8188eu: Convert non-standard variable types to regular ones 
These include changing s1Byte to s8, etc.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-14 12:03:28 -05:00
Larry Finger
9dd1827027 rtl8188eu: Fix checkpatch errors in include/*.h - part 1 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-13 21:01:38 -05:00
Larry Finger
527bc4066f rtl8188eu: Fix checkpatch errors in core/rtw_xmit.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-02 22:16:03 -05:00
Larry Finger
7b59aa12db rtl8188eu: Fix checkpatch errors in core/rtw_wlan_util.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-02 12:12:37 -05:00
Larry Finger
9e855cb914 rtl8188eu: Fix checkpatch errors in core/rtw_sta_mgt.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-01 13:33:20 -05:00
Larry Finger
79b808ad13 rtl8188eu: Fix checkpatch errors in core/rtw_sreset.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-01 13:10:46 -05:00
Larry Finger
539fbbc437 rtl8188eu: Fix checkpatch errors for core/rtw_security.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-08-01 12:59:07 -05:00
Larry Finger
37c22805d1 rtl8188eu: Fix checkpatch errors in core/rtw_rf.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 21:46:50 -05:00
Larry Finger
ef1472a558 rtl8188eu: Fix checkpatch errors in core/rtw_recv.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 21:43:28 -05:00
Larry Finger
09a9f2fc31 rtl8188eu: Fix checkpatch errors in core/rtw_mlme_ext.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 21:12:42 -05:00
Larry Finger
b03da9e17a rtl8188eu: Fix checkpatch errors in core/rtw_pwrctrl.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 17:27:03 -05:00
Larry Finger
cee2832224 rtl8188eu: Fix checkpatch errors in core/rtw_p2p.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 17:26:54 -05:00
Larry Finger
a7a6040bb2 rtl8188eu: Fix checkpatch errors in core/rtw_mp_ioctl.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 17:26:46 -05:00
Larry Finger
7b5b86f621 rtl8188eu: Fix checkpatch errors in core/rtw_mp.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-31 17:26:37 -05:00
Larry Finger
1212be3220 rtl8188eu: Fix checkpatch errors in core/rtw_mlme.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-29 22:59:07 -05:00
Larry Finger
6e2ae99fd8 rtl8188eu: Fix checkpatch errors in core/rtw_led.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-29 15:06:54 -05:00
Larry Finger
dc4ccb5db1 rtl8188eu: Fix checkpatch ERRORS in core/rtw_iol.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-29 11:54:09 -05:00
Larry Finger
ee5b8bfeeb rtl8188eu: Fix checkpatch ERRORs for core/rtw_ioctl_set.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-29 00:29:55 -05:00
Larry Finger
c0187151f4 rtl8188eu: Fix checkpatch errors in core/rtw_io.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-28 19:15:57 -05:00
Larry Finger
a96e65934d rtl8188eu: Dix checkpatch errors in core/rtw_ieee80211.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-28 18:59:03 -05:00
Larry Finger
7e4cdda1c0 rtl8188eu: Fix checkpatch ERRORs in core/rtw_efuse.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-28 12:00:21 -05:00
Larry Finger
4f7065928d rtl8188eu: Fix checkpatch ERRORs in core/rtw_debug.c 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-28 10:22:04 -05:00
Larry Finger
a839bebbbd rtl8188eu: Fix checkpatch ERRORs in core/rtw_cmd.c 
Some WARNINGs and CHECKs remain.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-27 14:49:25 -05:00
Larry Finger
29ada234b0 rtl8188eu: Fix checkpatch errors in core/rtw_br_ext.c 
There are CHECKS and WARNINGS remaining.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-27 13:27:48 -05:00
Larry Finger
954eab3527 rtl8188eu: Fix checkpatch errors in core/rtw_ap.c 
Some CHECKS and WARNINGS remain.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-27 12:51:59 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT 
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-27 10:56:06 -05:00
Larry Finger
237fa4c813 rtl8188eu: Remove a few more configuration variables 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-27 00:03:32 -05:00
Larry Finger
5881f66af5 rtl8188eu: Remove DBG_RX_SIGNAL_DISPLAY_PROCESSING - not defined 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 23:51:57 -05:00
Larry Finger
1e96c9a1d4 rtl8188eu: Remove MP_DRIVER conditionals - selected 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 22:26:30 -05:00
Larry Finger
a0911e4309 rtl8188eu: Remove RATE_ADAPTIVE_SUPPORT - this is selected 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 21:47:50 -05:00
Larry Finger
4f92869c5b rtl8188eu: Remove "if 1" statements 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 21:37:57 -05:00
Larry Finger
35044413a3 rtl8188eu: Fix remainder of trivial typedef statements 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 20:15:31 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc. 
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
 2013-07-26 20:08:39 -05:00