Commit graph

148 commits

Author SHA1 Message Date
Larry Finger
f4d1258158 r8188eu: Fix skb leak in usb_read_port_complete()
In the completion routine for a usb_fill_bulk_urb() call, an skb is
leaked whenever the status of the USB transaction is not zero. A call
to skb_put() is needed to fix the problem.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-07 10:13:38 -05:00
Álvaro Fernández Rojas
04251b45bb Remove more unused variables from hal files. 2013-09-27 22:01:01 +02:00
Álvaro Fernández Rojas
9365e8f151 Remove unused variables from hal files. 2013-09-27 21:41:36 +02:00
Larry Finger
a5e071f8da rtl8188eu: Fix smatch warnings in hal/rtl8188e_hal_init.c
Smatch displays the following:
  CHECK   /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:1695 hal_EfusePgPacketWriteData() info: ignoring unreachable code.
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2269 Hal_ReadPowerValueFromPROM_8188E() error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2466 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2468 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2474 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2475 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:32:25 -05:00
Larry Finger
1d3cceea6a rtl8188eu: Fix smatch warnings in hal/HalPhyRf_8188e.c
Smatch reports the following:
  CHECK   /home/finger/rtl8188eu/hal/HalPhyRf_8188e.c
/home/finger/rtl8188eu/hal/HalPhyRf_8188e.c:1878 PHY_APCalibrate_8188E() info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:14:11 -05:00
Larry Finger
4749e2c19e rtl8188eu: Fix smatch warning in hal/usb_ops_linux.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/hal/usb_ops_linux.c
/home/finger/rtl8188eu/hal/usb_ops_linux.c:630 usb_read_port() warn: variable dereferenced before check 'precvbuf' (see line 627)

The code is refactored.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 17:58:13 -05:00
Larry Finger
7446992dc4 rtl8188eu: Remove include/circ_buf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-15 20:09:00 -05:00
Larry Finger
2db42a3fbf rtl8188eu: Convert non-standard variable types to regular ones
These include changing s1Byte to s8, etc.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-14 12:03:28 -05:00
Larry Finger
a311b57c32 rtl8188eu: Fix remaining checkfile errors in hal/*.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 22:23:49 -05:00
Larry Finger
f527ca59c9 rtl8188eu: Fix checkpatch errors in hal/rtl8188e_mp.c, hal/rtl8188e_phycfg.c, and hal/rtl8188e_rf6052.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 09:31:29 -05:00
Larry Finger
9c3c9ddc8c rtl8188eu: Fix checkpatch errors for hal/rtl8188e_hal_init.c and hal/rtl8188e_dm.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 00:41:21 -05:00
Larry Finger
5a29bf421e rtl8188eu: Fix checkpatch errors for hal/rtl8188e_cmd.c, hal/odm_interface.c, hal/odm_RegConfig8188E.c, and hal/odm_RTL8188E.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-07 16:24:48 -05:00
Larry Finger
f083317939 rtl8188eu: Fix checkpatch errors in hal/odm_HWConfig.c and hal/odm_debug.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-07 14:30:06 -05:00
Larry Finger
bc21c61991 rtl8188eu: Fix checkpatch errors in hal/odm.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 22:34:32 -05:00
Larry Finger
98a63bfadd rtl8188eu: Fix checkpatch errors and checks in hal/HalPwrSeqCmd.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 15:50:37 -05:00
Larry Finger
cacca3d6b2 rtl8188eu: Fix checkpatch errors in hal/HalPhyRf.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 15:37:28 -05:00
Larry Finger
f1cf522a99 rtl8188eu: Fix checkpatch errors in hal/HalPhyRf_8188e.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 15:24:06 -05:00
Larry Finger
574e5bb72b rtl8188eu: Fix checkpatch errors and warnings in hal/hal_intf.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-04 18:08:37 -05:00
Larry Finger
e0542cf999 rtl8188eu: Fix checkfile errors in hal/HalHWImg8188E_RF.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-04 17:34:48 -05:00
Larry Finger
4e6e85f466 rtl8188eu: Fix checkpatch errors in hal/HalHWImg8188E_MAC.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-04 17:14:19 -05:00
Larry Finger
265bcabda9 rtl8188eu: Fix errors in hal/hal_com.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-04 15:12:30 -05:00
Larry Finger
716a0e47ff rtl8188eu: Fix checkpatch errors in hal/Hal8188EPwrSeq.c and hal/HalHWImg8188E_BB.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-04 14:20:21 -05:00
Larry Finger
a153120e2e rtl8188eu: Fix checkpatch errors and warnings in hal/Hal8188EFWImg_CE.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-03 11:04:21 -05:00
Larry Finger
6d1127b181 rtl8188eu: Remove dead code for CONFIG_FILE_FWIMG
Eventually the internal FW will be replaced by an external file; however,
the code will be redone. Remove this stuff for now.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 11:09:18 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 10:56:06 -05:00
Larry Finger
f55990fd29 rtl8188eu: Remove most of the remaining parameters from autoconf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 22:47:25 -05:00
Larry Finger
1e96c9a1d4 rtl8188eu: Remove MP_DRIVER conditionals - selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 22:26:30 -05:00
Larry Finger
caeea00c03 rtl8188eu: Remove SIC_ENABLE and SIC_HW_SUPPORT - neither selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 22:13:06 -05:00
Larry Finger
90575aca87 rtl8188eu: Remove code for ENABLE_USB_DROP_INCORRECT_OUT and DISABLE_BB_RF
Neither is selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:58:08 -05:00
Larry Finger
6b83fa17db rtl8188eu: Remove POWER_TRAINING_ACTIVE - selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:52:05 -05:00
Larry Finger
a0911e4309 rtl8188eu: Remove RATE_ADAPTIVE_SUPPORT - this is selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:47:50 -05:00
Larry Finger
4f92869c5b rtl8188eu: Remove "if 1" statements
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:37:57 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 20:08:39 -05:00
Larry Finger
e8012b9521 rtl8188eu: Convert typedef statement in include/rtw_pwrctrl.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 18:15:45 -05:00
Larry Finger
b2804a6af7 rtl8188eu: Convert typedef statement from include/hal_intf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 18:04:37 -05:00
Larry Finger
476eaf9a4e rtl8188eu: Convert typedef statements from include/odm_HWConfig.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 17:56:14 -05:00
Larry Finger
a4a1896f86 rtl8188eu: Convert typedef statements in include/Hal8188EPwrSeq.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 17:29:07 -05:00
Larry Finger
8d9e1697d6 rtl8188eu: Convert typedef statements in include/odm_HWConfig.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 16:52:36 -05:00
Larry Finger
ec5245f648 rtl8188eu: Convert typedef statements in include/rtw_rf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 16:27:19 -05:00
Larry Finger
5cfecb6edc rtl8188eu: Convert most typedef statements in include/rtw_mp.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 16:08:55 -05:00
Larry Finger
7161cf35ba rtl8188eu: Convert typedef statements in include/rtl8188e_hal.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 15:54:27 -05:00
Larry Finger
75fa3f7c0b rtl8188eu: Convert typedef statements in include/odm_types.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 15:25:06 -05:00
Larry Finger
cf3dfeecf9 rtl1811eu: Convert typedef statements in include/rtl8188e_cmd.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 14:58:04 -05:00
Larry Finger
7449a3d03b rtl8188eu: Convert typedef statements in include/Hal8188EPhyCfg.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 13:36:38 -05:00
Larry Finger
f311a752bb rtl8188eu: Convert all typedef statements in include/odm.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 11:20:42 -05:00
Larry Finger
3d755766c9 rtl8188eu: Convert typedef for _list to struct list_head
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-25 09:49:25 -05:00
Larry Finger
689d01adf6 rtl8188eu: Convert typedef for _queue to struct __queue
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:55:38 -05:00
Larry Finger
3e3d47445a rtl8188eu: Convert typedef for _pkt into struct sk_buff
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:03:54 -05:00
Larry Finger
2685b52404 rtl8188eu: Replace several local size defines/typedefs with kernel header version
These include the following:

SIZE_T => size_t
SSIZE_T => ssize_t
SIZE_PTR => size_t

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 12:19:14 -05:00
Larry Finger
41ad3e27c6 rtl8188eu: Convert some typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 22:39:20 -05:00