Commit graph

329 commits

Author SHA1 Message Date
Larry Finger
2bcb8d3cb2 rtl8188eu: Remove CONFIG_SKB_COPY
This one is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-03 15:18:07 -06:00
Larry Finger
0b5c6eb35b rtl8188eu: Change BOOLEAN to bool
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 17:21:23 -06:00
Larry Finger
ed192682fe rtl_8188eu: Remove CONFIG_MMC_PM_KEEP_POWER, and CONFIG_WOWLAN
These parameters are not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 17:03:18 -06:00
Larry Finger
4b61fd5bf7 rtl8188eu: Remove CONFIG_WAPI_SUPPORT
This symbol is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 11:12:58 -06:00
Larry Finger
1d52d1060a rtl8188eu: Remove CONFIG_INTEL_WIDI
This symbol was not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 10:54:45 -06:00
Larry Finger
9b21efa5d6 rtl8188eu: Remove CONFIG_FTP_PROTECT
This one is not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 10:43:05 -06:00
Larry Finger
44ff69caaa rtl8188eu: Remove CONFIG_DISABLE_MCS13TO15
This one is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-02 10:39:28 -06:00
Larry Finger
7f426e6764 rtl8188eu: Remove CONFIG_LED and related configuration variables
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 22:55:42 -06:00
Larry Finger
27f745af7b rtl8188eu: Remove some configuration variables defined when CONFIG_P2P is defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 22:48:40 -06:00
Larry Finger
7b6e9a069d rtl8188eu: Convert CONFIG_FIND_BEST_CHANNEL to CONFIG_AP_MODE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 11:00:26 -06:00
Larry Finger
1155811fcf rtl8188eu: Remove CONFIG_IOL
This parameter is defined by default.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-01 10:36:23 -06:00
Larry Finger
427ab12050 rtl8188eu: Remove CONFIG_IOL_NEW_GENERATION
This one is selected by defining CONFIG_IOL.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-28 16:12:47 -06:00
Larry Finger
eba06c1708 rtl8188eu: Remove CONFIG_WIFI_TEST
The one is never selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-28 16:02:57 -06:00
Larry Finger
d264b3ae00 rtl8188eu: Remove CONFIG_DEAUTH_BEFORE_CONNECT
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-27 20:14:21 -06:00
Larry Finger
1a2d9b8514 rtl8188eu: Remove CONFIG_NEW_SIGNAL_STAT_PROCESS
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-27 20:11:07 -06:00
Larry Finger
72bd29ec15 rtl8188eu: Remove CONFIG_LAYER2_ROAMING
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-27 15:46:32 -06:00
Larry Finger
3263fc1330 rtl8188eu: Remove CONFIG_USB_TX_AGGREGATION
This one was defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-26 14:19:01 -06:00
Larry Finger
42a1d09fe1 rtl8188eu: Remove CONFIG_USE_USB_BUFFER_ALLOC_RX
This was never defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-26 14:06:11 -06:00
Larry Finger
f6fb81d6a0 rtl8188eu: Remove antenna diversity configuration variables
Always selected are CONFIG_ANTENNA_DIVERSITY and CONFIG_hW_ANTENNA_DIVERSITY.
Not selected is CONFIG_SW_ANTENNA_DIVERSITY.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-25 15:41:18 -06:00
Larry Finger
dae15933ce rtl8188eu: Remove CONFIG_LPS
This symbol is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 20:32:00 -06:00
Larry Finger
e932bd9250 rtl8188eu: Remove CONFIG_LPS_LCLK
This symbol is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 20:22:38 -06:00
Larry Finger
4bfca25407 rtl8188eu: Remove CONFIG_LPS_RPWM_TIMER
This symbol is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:34:06 -06:00
Larry Finger
636309c83f rtl8188eu: Remove SUPPORT_HW_RFOFF_DETECTED
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:26:03 -06:00
Larry Finger
7f75913cfb rtl8188eu: Remove CONFIG_IPS
This one is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:18:56 -06:00
Larry Finger
d9320ea25b rtl8188eu: Remove CONFIG_RECV_REORDERING_CTRL
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:04:11 -06:00
Larry Finger
cc8740eb70 rtl8188eu: Remove CONFIG_SET_SCAN_DENY_TIMER
This one is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-24 10:01:42 -06:00
Larry Finger
856f0de3ce rtl8188eu: Remove CONFIG_CFG80211_FORCE_COMPATIBLE_2_6_37_UNDER
This symbol is always defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-21 11:42:14 -06:00
Larry Finger
2b27b83d40 rtl8188eu: Remove CONFIG_80211N_HT
This one is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 20:30:23 -06:00
Larry Finger
37a28f802f rtl8188eu: Remove CONFIG_ACTIVE_KEEP_ALIVE_CHECK
This symbol is always defined. In addition, a number of defines that are commented
out in include/autoconf.h have been removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 20:07:27 -06:00
Larry Finger
49437ec417 rtl8188eu: Remove CONFIG_TX_MCAST2UNI
This parameter is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 10:11:36 -06:00
Larry Finger
0f3cbc1f0f rtl8188eu: Remove CONFIG_ATMEL_RC_PATCH
This quirk is never selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 10:05:28 -06:00
Larry Finger
8c846f57f0 rtl8188eu: Remove CONFIG_INTERRUPT_BASED_TXBCN and derivatives
These are never selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 09:59:38 -06:00
Larry Finger
8f5cbefdef rtl8188eu: Remove _CONFIG_NATIVEAP_MLME_ and CONFIG_NATIVEAP_MLME
The first is never defined. The second is always devined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 09:52:14 -06:00
Larry Finger
5ded2b3ded rtl8188eu: Remove CONFIG_XMIT_ACK and CONFIG_XMIT_ACK_POLLING
The first one was always selected. The second was not selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-20 09:37:42 -06:00
Larry Finger
5470a10d13 rtl8188eu: Remove CONFIG_IOCTL_CFG80211
This one is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 22:52:01 -06:00
Larry Finger
54abf571c4 rtl8188eu: Change C90 comments to /* */ form
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 15:34:32 -06:00
Larry Finger
9b5b5c4e12 rtl8188eu: Replace wrapper for memset
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 14:58:09 -06:00
Larry Finger
529328fd3d rtl8188eu: Replace wrapper for memcpy
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-19 14:50:04 -06:00
Larry Finger
120368c717 rtl8188eu: Remove dead code associated with BR_EXT_DEBUG
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-18 13:22:34 -06:00
Larry Finger
87f2c0473e rtl8188eu: More endian fixes
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-18 11:42:22 -06:00
Larry Finger
276a62340a rtl8188eu: Fix more endian issues
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-16 13:00:49 -06:00
Larry Finger
e8487f5809 rtl8188eu: Remove code selected by CONFIG_DUALMAC_CONCURRENT
This variable only applies to RTL8192DU.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-15 14:41:56 -06:00
Larry Finger
020675ff42 rtl8188eu: Remove code selected when CONFIG_CONCURRENT_MODE is defined
This parameter can only be set for RTL8192DU.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-15 14:31:30 -06:00
Larry Finger
d2b7e5be2d rtl8188eu: Remove code for DBG_MEMORY_LEAK
The kernel does a better job.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-14 20:27:38 -06:00
Larry Finger
f0f2a06c6d rtl8188eu: Fix a missing cpu_to_le16
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-09 17:28:30 -06:00
Larry Finger
24cbb514c5 rtl8188eu: Fix more endian issues
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-02-09 14:10:15 -06:00
Larry Finger
5b8f5bc69d rtl8188eu: More Sparse fixes
There are only a few more left. Most are in the P2P code

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-29 21:41:53 -06:00
Larry Finger
481d6c817d rtl8188eu: Clean up more Sparse messages
There are still problems remaining, but those are believed to be cosmetic.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-29 15:27:28 -06:00
Larry Finger
6dc546efc8 rtl8188eu: Remove byte ordering routines
The kernel routines can handle everything that is needed

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-28 23:58:29 -06:00
Larry Finger
7c7f632ac7 rtl8188eu: Fix some sparse warnings
The driver did not work on PowerPC, which is big endian. This patch
fixes all the sparse warnings concerning improper use of __le16 and __le32
variables.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-27 23:14:58 -06:00
Larry Finger
9f59c77b0f rtl8188eu: Add header needed for ppc
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-26 20:58:16 -06:00
Larry Finger
cc84eb336a rtl8188eu: Cleanup read/write routines
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-26 20:52:43 -06:00
Larry Finger
a8e1fbf1f9 rtl8188eu: Remove __func_enter__ and __func_exit__
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-26 16:20:25 -06:00
Larry Finger
14c43aeb12 rtl8188eu: Fix error path for memory allocation failure
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-01-26 16:01:30 -06:00
Larry Finger
4b573cbd5a rtl8188eu: Replace UINT, USHORT and UCHAR with u32, u16, and u8
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-30 18:05:09 -06:00
Larry Finger
1038ee1874 rtl8188eu: Replace sNByte with appropriate s value
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-30 17:58:53 -06:00
Larry Finger
6b438a9749 rtl8188eu: Remove more unused files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-28 20:53:09 -06:00
Larry Finger
06334102cd rtl8188eu: Replace _FALSE and _TRUE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-28 20:13:24 -06:00
Larry Finger
17d1637977 rtl8188eu: Replace PVOID and VOID
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-28 20:07:17 -06:00
Larry Finger
b6b121512b rtl8188eu: Remove dead code inside #if 0
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-28 20:00:11 -06:00
Larry Finger
2d60bad9ad rtl8188eu: FRemove dead code for other than USB
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-28 11:13:03 -06:00
Larry Finger
6348961d3a rtl8188eu: Fix to build on modern kernels
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-27 16:41:28 -06:00
Larry Finger
bb33327257 rtl8188eu: Remove all trailing spaces from code
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-19 00:59:46 -06:00
Larry Finger
8db176767f rtl8188eu: Fix Sparse warnings in core/rtw_mlme_ext.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-18 22:28:04 -06:00
Larry Finger
202d20077c rtl8192eu: Replace typedefs for struct adapter
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-17 17:13:53 -06:00
Larry Finger
a9f33120c5 rtl8188eu: Flatten core/
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-16 22:26:13 -06:00
Larry Finger
b0c8a54865 rtl8188eu: Remove other device configurations from core and hal
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-16 18:58:56 -06:00
Larry Finger
17eaf0e045 rtl8188eu: Remove some unused files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-16 17:08:39 -06:00
Larry Finger
62ef49de15 rtl8188eu: Remove the PLATFORM_LINUX tests
This configuration parameter is always selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-15 18:29:43 -06:00
Larry Finger
dd606233f2 rtl8188eu: Remove dead code for FREEBSD
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-15 16:58:13 -06:00
Larry Finger
a68c6cc26e rtl8188eu: Remove code used only for Windows
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-15 14:28:28 -06:00
Larry Finger
2caee63170 rtl8188eu: Remove rest of dead code depending on CONFIG_MP_INCLUDED
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-15 13:49:38 -06:00
Larry Finger
a0c85b341e rtl8188eu: Remove some Sparse problems
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-14 23:08:37 -06:00
Larry Finger
065126d8ce rtl8188eu: Place driver rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104 in branch v4.1.8_9499
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-11 15:15:04 -06:00
Larry Finger
bad0b4cde4 rtl8188eu: Remove cases of two or more blank lines
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 18:00:05 -06:00
Larry Finger
e91077579f rtl8188eu: Remove _func_enter_ and _func_exit_ statements
Kernel tracing is more effective.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 16:31:15 -06:00
Larry Finger
849d585656 rtl8188eu: Fix some edit errors from replace spin lock wrappers
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 18:42:41 -06:00
Larry Finger
8b76b3b701 rtl8188eu: Convert spin lock macros
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 17:37:57 -06:00
Larry Finger
9fe0c17a65 rtl8188eu: Remove wrapper _rtw_spinlock_init
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 11:14:29 -06:00
Larry Finger
287f6491f3 rtl8188eu: Part 3 of the upgrades from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-20 00:12:27 -06:00
Larry Finger
ef77969222 rtl8188eu: More changes from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
This one completes the changes for rtw_mlme.c

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-19 18:03:11 -06:00
Larry Finger
c8a380cd16 rtl8188eu: Make updates from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
This patch is step 1 of many. This driver has much better sensitivity than
the previous version.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-19 14:32:12 -06:00
Larry Finger
41245153f4 r8188eu: Fix an le16 problem
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-13 16:28:55 -06:00
Larry Finger
c2741d0bec rtl8188eu: Fix compilation for kernels older that 2.6.36
These changes will apply at least back to 2.6.32.

From: Stas Sergeev <stsp@list.ru>
Signed-off-by: Stas Sergeev <stsp@list.ru>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-02-12 11:05:30 -06:00
Larry Finger
295bb23ffe rtl8188eu: Fix reporting of signal strength and quality
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-12-30 21:18:17 -06:00
Larry Finger
91938194fd rtl8188eu: Make this code look exactly like the code in the kernel version
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-11-29 16:10:20 -06:00
Larry Finger
19db43ecbd rtl8188eu: Backport kernel version
This driver was added to the kernel with version 3.12. The changes in that
version are now brought back to the GitHub repo. Essentually all of the code
is updated.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 12:45:47 -05:00
Larry Finger
3695d581c6 rtl8188eu: Fix AP problem introduced in commit 954eab3
Two code lines were accidentally deleted in the commit noted in subject.
Restore them.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-27 12:46:29 -05:00
Larry Finger
66ccf88866 rtl8188eu: Fix smatch warnings in core/rtw_security.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_security.c
/home/finger/rtl8188eu/core/rtw_security.c:2077 rijndaelKeySetupEnc() warn: '4' 4 can't fit into 4611686018427387903 'rk'
/home/finger/rtl8188eu/core/rtw_security.c:2108 rijndaelEncrypt() warn: '8' 8 can't fit into 4611686018427387903 'rk'

These warnings were fixed by removing a number of unused routines.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 23:09:00 -05:00
Larry Finger
c2a0523bb7 rtl8188eu: Fix smatch warning in core/rtw_xmit.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1560 dequeue_one_xmitframe() info: ignoring unreachable code.

A while loop that has a break in the first pss is converted to to an if statement.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 22:11:06 -05:00
Larry Finger
aa4ccbe53f rtl8188eu: Remove unused static data defines from core/rtw_recv.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-06 10:04:31 -05:00
Larry Finger
9580338a0b Merge branch 'next' of https://github.com/Noltari/rtl8188eu 2013-09-06 09:59:30 -05:00
Álvaro Fernández Rojas
27670d56d0 Move vars from rtw_recv.h to rtw_recv.c in order to prevent unused vars warnings when including rtw_recv.h.
Note that SNAP_ETH_TYPE_APPLETALK_DDP, SNAP_ETH_TYPE_TDLS, SNAP_HDR_APPLETALK_DDP, oui_8021h and oui_rfc1042 are still unused and can be commented out.
2013-09-06 12:09:58 +02:00
Larry Finger
96ba7d3cca rtl8188eu: Fix smatch warning in core/rtw_xmit.c
Smatch displays the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_xmit.c
/home/finger/rtl8188eu/core/rtw_xmit.c:1571 dequeue_one_xmitframe() info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:25:22 -05:00
Larry Finger
3be2cff4fe rtl8188eu: Fix smatch warning in core/rtw_wlan_util.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/core/rtw_wlan_util.c
/home/finger/rtl8188eu/core/rtw_wlan_util.c:1111 rtw_check_bcn_info() info: ignoring unreachable code.

This case had the _func_exit_ macro after a return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:22:23 -05:00
Álvaro Fernández Rojas
bf4d305a09 Fix duplicated use of BROADCOM_OUI2, leaving BROADCOM_OUI3 unused. 2013-09-06 02:45:38 +02:00
Álvaro Fernández Rojas
a7e9834fbc Remove unused variables from core files. 2013-09-06 02:44:02 +02:00
Larry Finger
65c4e60be3 rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c
Smatch reports the following problems:
  CHECK   /home/finger/rtl8188eu/core/rtw_ioctl_set.c
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:593 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:595 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:745 rtw_set_802_11_add_key() warn: was && intended here instead of ||?

The buffer overflow messages are due to an off-by-one problem. An if test skips code
for a value > 4. It should be >= 4.

The warning for a suspect logical operator was correct. With a logical or in the statement,
it made no sense.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:26:29 -05:00
Larry Finger
d1d8ed064b rtl8188eu: Fix smatch warning in core/rtw_ieee80211.c
Smatch reports the following warning:
  CHECK   /home/finger/rtl8188eu/core/rtw_ieee80211.c
/home/finger/rtl8188eu/core/rtw_ieee80211.c:161 rtw_set_ie() info: ignoring unreachable code.

This warning is caused by a _func_exit_ macro placed after the return.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:10:47 -05:00
Larry Finger
8f7fde8d6a rtl8188eu: Fix smatch warnings in core/rtw_efuse.c
Smatch reports the following warnings:

  CHECK   /home/finger/rtl8188eu/core/rtw_efuse.c
/home/finger/rtl8188eu/core/rtw_efuse.c:646 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:655 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:738 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8188eu/core/rtw_efuse.c:747 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8

These are due to an off-by-one error in an array size.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:08:39 -05:00