Commit graph

34 commits

Author SHA1 Message Date
Larry Finger
65c4e60be3 rtl8188eu: Fix smatch problems in core/rtw_ioctl_set.c
Smatch reports the following problems:
  CHECK   /home/finger/rtl8188eu/core/rtw_ioctl_set.c
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:593 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:595 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:599 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8188eu/core/rtw_ioctl_set.c:745 rtw_set_802_11_add_key() warn: was && intended here instead of ||?

The buffer overflow messages are due to an off-by-one problem. An if test skips code
for a value > 4. It should be >= 4.

The warning for a suspect logical operator was correct. With a logical or in the statement,
it made no sense.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:26:29 -05:00
Larry Finger
ee5b8bfeeb rtl8188eu: Fix checkpatch ERRORs for core/rtw_ioctl_set.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-29 00:29:55 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 10:56:06 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 20:08:39 -05:00
Larry Finger
476eaf9a4e rtl8188eu: Convert typedef statements from include/odm_HWConfig.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 17:56:14 -05:00
Larry Finger
ed7a8186fe rtl8188eu: Convert typedef statements in include/rtw_mlme.h
2
2013-07-26 16:37:24 -05:00
Larry Finger
3d755766c9 rtl8188eu: Convert typedef for _list to struct list_head
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-25 09:49:25 -05:00
Larry Finger
689d01adf6 rtl8188eu: Convert typedef for _queue to struct __queue
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:55:38 -05:00
Larry Finger
41ad3e27c6 rtl8188eu: Convert some typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 22:39:20 -05:00
Larry Finger
a01908ab27 rtl8188eu: Convert the typedef statements in include/wlan_bssdef.h
One remains that I still do not know how to convert; however, it has been
moved to os_dep/ioctl_linux.c where it is used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 21:31:04 -05:00
Larry Finger
dfe35fb489 rtl8188eu: Remove CONFIG_USB_VENDOR_REQ_MUTEX - not selected
This change made include/drv_conf.h and core/rtw_ioctl_query.c redundant.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 13:00:05 -05:00
Larry Finger
f4a1669097 rtl8188eu: Rework CONFIG_NATIVEAP_MLME
This variable is set in autoconf.h to be defined whenever CONFIG_AP is
defined. As there is no need for both parameters, CONFIG_NATIVEAP_MLME is
renamed to CONFIG_AP. In addition, the dead code associated with the one
instance where of _CONFIG_NATIVEAP_MLME_ is removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 11:01:46 -05:00
Larry Finger
632cdeeec8 rtl8188eu: Remove CONFIG_VALIDATE_SSID
This parameter is not set.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 10:48:54 -05:00
Larry Finger
085a651d9c rtl8188eu: Remove CONFIG_MP_INCLUDED
This one is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:55:30 -05:00
Larry Finger
167e245287 rtl8188eu: Remove CONFIG_LPS
This parameter is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:25:11 -05:00
Larry Finger
0db3ae417e rtl8188eu: Remove CONFIG_LAYER2_ROAMING_RESUME
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-12 22:38:53 -05:00
Larry Finger
acda213bd2 rtl8188eu: Remove dead code associated with WAPI
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-12 01:29:15 -05:00
Larry Finger
0e4009c999 rtl8188eu: Remove dead code for other than USB
The vendor code has pieces of code for PCI, SDIO, and GSPI. Remove it
and CONFIG_USB_HCI.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 13:35:36 -05:00
Larry Finger
1c5cb9ca00 rtl8199eu: Remove all PLATFORM_LINUX ifdefs
This option is always chosen.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 00:30:22 -05:00
Larry Finger
a3ca3380b5 rtl8188eu: Remove dead code used for PLATFORM_WINDOWS, PLATFORM_OS_XP, and PLATFORM_OS_CE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-10 20:46:15 -05:00
Larry Finger
d2c90ee304 rtl8188eu: Change C90 comments to kernel form for files in core/
This commit also includes some sparse fixes for endian issues.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-09 17:38:46 -05:00
Larry Finger
fb786d0283 rtl8188eu: Fix all W=1 warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-21 13:41:29 -05:00
Larry Finger
254539b5ec rtl8188eu: Fix more sparse warnings
Most of these are for endian issues

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-07 09:43:09 -05:00
Larry Finger
925510ff1a rtl8188eu: Change all MAC_FMT to %pM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-30 15:51:53 -05:00
Larry Finger
9cef34aa09 rtl8188eu: Change _FALSE and _TRUE to false and true
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 22:02:10 -05:00
Larry Finger
96adb823b9 rtl8188eu: Update logging
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 18:35:42 -05:00
Larry Finger
f6b0b0658a rtl8188eu: Convert VOID to void
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 23:37:45 -05:00
Larry Finger
f5f3863bc5 rtl8188eu: Remove trailing white space from all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 23:28:07 -05:00
Larry Finger
77e736c66a rtl8188eu: Remove dead code inside #if 0 ... #endif
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 16:16:10 -05:00
Larry Finger
d4fa4d178f Replace __FUNCTION__ with __func__
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-09 11:23:32 -05:00
Larry Finger
4620c2a956 Remove the execute privilege bit on all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:36:05 -05:00
Larry Finger
d25660e511 Remove space before \n in formats
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:09:18 -05:00
Larry Finger
a55f866a62 Change "if(" to "if (" and the same changes for "while", "for", "switch" and "do"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:04:25 -05:00
Larry Finger
85df502f5b Initial commit of flattened driver to repo
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 16:45:39 -05:00