Commit graph

182 commits

Author SHA1 Message Date
Larry Finger
126d786bd4 rtl8188eu: Fix fallthrough statements
In kernel 5.4.0-rc3, the kernel includes define a "fallthrough" macro,
which breaks a couple of the statements in the driver. Use __fallthrough__
instead.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2019-10-16 11:10:48 -05:00
Larry Finger
ea8530e2b3 Merge branch 'master' of http://github.com/lwfinger/rtl8188eu 2019-09-28 13:17:09 -05:00
Larry Finger
2525cdee47 rtl8188eu: Fis fall-through warning
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2019-09-28 13:14:03 -05:00
Larry Finger
95a4b1ec29 rtl8188eu: Fix duplicate test
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2019-09-26 12:59:31 -05:00
Larry Finger
1f08a062ad rtl8188eu: Updates for timer changes in kernel 4.15
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-12-05 16:03:03 -06:00
Larry Finger
ce54314518 rtl8188eu: Silence meaningless log message
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-01-09 13:24:49 -06:00
Larry Finger
ced2b64a11 rtl8188eu: Remove "enum ODM_RF_RADIO_PATH" and ODM_RF_PATH_x
These are already expressed as "enum rf_radio_path" and RF_PATH_x. Having
two definitions is ridiculous.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-14 19:23:53 -06:00
Larry Finger
3c79709126 rtl8188eu: Remove ODM_RF_PATH_MAX
This is always equal to RF_PATH_MAX.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-13 15:43:45 -06:00
Larry Finger
c73b464cae rtl8188eu: Remove symbol MAX_RF_PATH
This one is set to RF_PATH_MAX.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-13 15:40:00 -06:00
Larry Finger
f9dbfb74dc rtl8188eu: Remove symbol MAX_RF_PATH_NUMS
This one is always equal to RF_PATH_MAX.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-13 15:36:13 -06:00
Larry Finger
61690cbca6 rtl8188eu: rtw_get_current_time() is jiffies
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:20:06 -06:00
Larry Finger
209e50ad60 rtlwifi: Remove list-handling macros
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 15:06:22 -06:00
Larry Finger
567257655f rtl8188eu: Replace LIST_CONTAINOR with container_of
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 10:40:44 -06:00
Larry Finger
7fd86158bf rtl8188eu: Change union recv_frame to struct
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 10:35:48 -06:00
Larry Finger
89efde68f8 rtl8188eu: Remove wrapper around memcmp()
Caution: The wrapper inverts the state.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-13 09:38:17 -06:00
Larry Finger
9ad78a5b0d rtl8188eu: Remove wrapper around INIT_LIST_HEAD()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 23:13:40 -06:00
Larry Finger
545d963a9e rtl8188eu: Remove wrapper for memset()
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 22:43:35 -06:00
Larry Finger
15519e9bf3 rtl8188eu: Clean up the section that reads the EEPROM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 20:43:14 -06:00
Larry Finger
ed2c3ab733 rtl8188eu: Rework endianess
Several of the struct items related to on-air data must be little endian.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-12 12:15:07 -06:00
Larry Finger
bad0b4cde4 rtl8188eu: Remove cases of two or more blank lines
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 18:00:05 -06:00
Larry Finger
e91077579f rtl8188eu: Remove _func_enter_ and _func_exit_ statements
Kernel tracing is more effective.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-12-01 16:31:15 -06:00
Larry Finger
849d585656 rtl8188eu: Fix some edit errors from replace spin lock wrappers
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 18:42:41 -06:00
Larry Finger
8b76b3b701 rtl8188eu: Convert spin lock macros
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 17:37:57 -06:00
Larry Finger
9fe0c17a65 rtl8188eu: Remove wrapper _rtw_spinlock_init
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-28 11:14:29 -06:00
Larry Finger
1d89650644 Merge branch 'master' of http://github.com/lwfinger/rtl8188eu 2014-11-24 14:32:19 -06:00
Larry Finger
486757db0d r8188eu: Fix reading of EEPROM on big-endian hardware
Signed-off-by: Larry Finger <l]Larry.Finger@lwfinger.net>
2014-11-24 14:29:11 -06:00
Larry Finger
287f6491f3 rtl8188eu: Part 3 of the upgrades from rtl8188EUS_rtl8189ES_linux_v4.1.8_9499.20131104
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-20 00:12:27 -06:00
Larry Finger
dc10076d5c r8188eu: Make error in EEPROMId log even at default debug level
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-12 18:42:52 -06:00
Larry Finger
7c902ec968 rtl8188eu: Improve firmware loading diagnostics
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2014-11-12 11:18:04 -06:00
Stas Sergeev
499e15d791 make firmware buffer persistent to not request firmware on every access 2014-02-14 13:46:49 -06:00
Larry Finger
295bb23ffe rtl8188eu: Fix reporting of signal strength and quality
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-12-30 21:18:17 -06:00
Larry Finger
91938194fd rtl8188eu: Make this code look exactly like the code in the kernel version
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-11-29 16:10:20 -06:00
Larry Finger
d53cd09c9d staging: r8188eu: Convert driver to use external firmware
As originally submitted, this driver acquired its firmware from data
statements embedded in the source code. This information has been extracted
into a binary file that has been accepted into the linux-firmware git
repo as commit ffc47f1 entitled "rtlwifi: Add new firmware files for
rtl8188eu". This patch switches the driver to use this file, and deletes
the firmware data from the source.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 16:23:12 -05:00
Larry Finger
19db43ecbd rtl8188eu: Backport kernel version
This driver was added to the kernel with version 3.12. The changes in that
version are now brought back to the GitHub repo. Essentually all of the code
is updated.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-19 12:45:47 -05:00
Larry Finger
f4d1258158 r8188eu: Fix skb leak in usb_read_port_complete()
In the completion routine for a usb_fill_bulk_urb() call, an skb is
leaked whenever the status of the USB transaction is not zero. A call
to skb_put() is needed to fix the problem.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-10-07 10:13:38 -05:00
Álvaro Fernández Rojas
04251b45bb Remove more unused variables from hal files. 2013-09-27 22:01:01 +02:00
Álvaro Fernández Rojas
9365e8f151 Remove unused variables from hal files. 2013-09-27 21:41:36 +02:00
Larry Finger
a5e071f8da rtl8188eu: Fix smatch warnings in hal/rtl8188e_hal_init.c
Smatch displays the following:
  CHECK   /home/finger/rtl8188eu/hal/rtl8188e_hal_init.c
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:1695 hal_EfusePgPacketWriteData() info: ignoring unreachable code.
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2269 Hal_ReadPowerValueFromPROM_8188E() error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2466 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2468 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2474 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
/home/finger/rtl8188eu/hal/rtl8188e_hal_init.c:2475 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:32:25 -05:00
Larry Finger
1d3cceea6a rtl8188eu: Fix smatch warnings in hal/HalPhyRf_8188e.c
Smatch reports the following:
  CHECK   /home/finger/rtl8188eu/hal/HalPhyRf_8188e.c
/home/finger/rtl8188eu/hal/HalPhyRf_8188e.c:1878 PHY_APCalibrate_8188E() info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 22:14:11 -05:00
Larry Finger
4749e2c19e rtl8188eu: Fix smatch warning in hal/usb_ops_linux.c
Smatch shows the following:
  CHECK   /home/finger/rtl8188eu/hal/usb_ops_linux.c
/home/finger/rtl8188eu/hal/usb_ops_linux.c:630 usb_read_port() warn: variable dereferenced before check 'precvbuf' (see line 627)

The code is refactored.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 17:58:13 -05:00
Larry Finger
7446992dc4 rtl8188eu: Remove include/circ_buf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-15 20:09:00 -05:00
Larry Finger
2db42a3fbf rtl8188eu: Convert non-standard variable types to regular ones
These include changing s1Byte to s8, etc.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-14 12:03:28 -05:00
Larry Finger
a311b57c32 rtl8188eu: Fix remaining checkfile errors in hal/*.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 22:23:49 -05:00
Larry Finger
f527ca59c9 rtl8188eu: Fix checkpatch errors in hal/rtl8188e_mp.c, hal/rtl8188e_phycfg.c, and hal/rtl8188e_rf6052.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 09:31:29 -05:00
Larry Finger
9c3c9ddc8c rtl8188eu: Fix checkpatch errors for hal/rtl8188e_hal_init.c and hal/rtl8188e_dm.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-08 00:41:21 -05:00
Larry Finger
5a29bf421e rtl8188eu: Fix checkpatch errors for hal/rtl8188e_cmd.c, hal/odm_interface.c, hal/odm_RegConfig8188E.c, and hal/odm_RTL8188E.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-07 16:24:48 -05:00
Larry Finger
f083317939 rtl8188eu: Fix checkpatch errors in hal/odm_HWConfig.c and hal/odm_debug.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-07 14:30:06 -05:00
Larry Finger
bc21c61991 rtl8188eu: Fix checkpatch errors in hal/odm.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 22:34:32 -05:00
Larry Finger
98a63bfadd rtl8188eu: Fix checkpatch errors and checks in hal/HalPwrSeqCmd.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 15:50:37 -05:00
Larry Finger
cacca3d6b2 rtl8188eu: Fix checkpatch errors in hal/HalPhyRf.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-08-06 15:37:28 -05:00