Commit graph

641 commits

Author SHA1 Message Date
Larry Finger
b8bfb4c958 rtl8188eu: Remove symbol MAX_RF_PATH_NUMS
This one is always equal to RF_PATH_MAX.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-02-14 19:34:21 -06:00
Larry Finger
37a56bca8b rtl8188eu: Move arrays off stack in translate_scan()
A user has reported a stack overflow panic in this routine. This patch
removes at least 782 bytes from the stack.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2016-01-21 20:08:06 -06:00
Larry Finger
69faa02ea5 rtl8723bs: Remove second interface name
Only the RTL8192D chips have multiple interfaces per chip, thus
this logic has no value here.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-09-26 13:54:47 -05:00
Larry Finger
2601c36dd9 rtl8723bs: Remove rtw_chip_version as module parameter
This parameter might be useful when the original driver was developed,
but it is useless in production code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-09-26 13:22:28 -05:00
Larry Finger
69fded9155 rtl8188eu: Cancel more timers on exit
A quick look shows the new ones have not been stopped.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-09-14 20:41:35 -05:00
Larry Finger
8ac0b5364d rtl8188eu: Replace LONG variants with the standard uxx form
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-09-08 00:04:30 -05:00
Larry Finger
429924c7ed rtl8188eu: Protect against pfhdr NULL
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-18 18:00:21 -05:00
Larry Finger
fc326e6a07 rtl8188eu: Remove CONFIG_WAKELOCK, CONFIG_HAS_EARLYSUSPEND, and CONFIG_ANDROID_POWER
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-17 10:23:46 -05:00
Larry Finger
549cb92f47 rtl8188eu: Remove CONFIG_INTEL_PROXIM
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-17 10:11:05 -05:00
Larry Finger
c010b6d78f rtl8188eu: Add header
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-17 09:58:09 -05:00
Larry Finger
3a3339b715 rtl8188eu: Replace degub macro DBG_871X with DBG_88E
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 16:38:30 -05:00
Larry Finger
1e6accffc4 rtl8188eu: Remove wrapper routine rtw_get_current_time()
This wrapper can be replaced with jiffies.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 16:35:29 -05:00
Larry Finger
e6a0d110e4 rtl8188eu: Fix some instances where open bracket should be moved to previous line
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 16:21:55 -05:00
Larry Finger
11ab93f073 rtl8188eu: Remove double blank lines in core/*.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:44:41 -05:00
Larry Finger
51e6fae39e rtl8188eu: Chnage "=NULL" to "= NULL"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:31:56 -05:00
Larry Finger
16d2a24227 rtl8188eu: Change "}else{" and variants to "} else {"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:27:00 -05:00
Larry Finger
0a97479cee rtl8188eu: Change "){" to ") {"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:24:16 -05:00
Larry Finger
c137ff21e5 rtl8188eu: Change "==0" to "== 0"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:22:58 -05:00
Larry Finger
83488f50f7 rtl8188eu: Add spaces after comma, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:19:16 -05:00
Larry Finger
9ee6ae40c3 rtl8188eu: Change "for(" to "for ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:06:32 -05:00
Larry Finger
c818db1282 rtl8188eu: Change "switch(" to "switch ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:05:44 -05:00
Larry Finger
8e22f0d2e8 rtl8188eu: Change "while(" to "while ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:04:12 -05:00
Larry Finger
6ead3e77dc rtl8188eu: Change all "if(" to "if ("
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:02:34 -05:00
Larry Finger
aa89a39a09 rtl8188eu: Remove spaces before quoted newline
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-15 13:00:19 -05:00
Larry Finger
b8f73d9a8f rtl8188eu: Fix Sparse warnings in core/rtw_sta_mgt.c
Sparse reports the following:

  CHECK   /home/finger/rtl8188eu/core/rtw_sta_mgt.c
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:32:6: warning: symbol '_rtw_init_stainfo' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:166:9: warning: symbol '_rtw_free_sta_xmit_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_sta_mgt.c:174:6: warning: symbol 'rtw_mfree_stainfo' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 23:12:02 -05:00
Larry Finger
3ead4034f3 rtl8188eu: Fix Sparse warnings in core/rtw_recv.c
Sparse reports the following:

  CHECK   /home/finger/rtl8188eu/core/rtw_recv.c
/home/finger/rtl8188eu/core/rtw_recv.c:127:6: warning: symbol 'rtw_mfree_recv_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:845:6: warning: symbol 'count_rx_stats' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:1878:6: warning: symbol 'wlanhdr_to_ethhdr' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:2168:5: warning: symbol 'amsdu_to_msdu' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_recv.c:2693:5: warning: symbol 'process_recv_indicatepkts' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 23:04:53 -05:00
Larry Finger
cc88df7da3 rtl8188eu: Fix Sparse problems in core/rtw_mlme_ext.c
Sparse reports the following:

  CHECK   /home/finger/rtl8188eu/core/rtw_mlme_ext.c
/home/finger/rtl8188eu/core/rtw_mlme_ext.c:9446:6: warning: symbol '_linked_rx_signal_strehgth_display' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme_ext.c:8520:6: warning: context imbalance in 'start_clnt_join' - different lock contexts for basic block

The second warning was due to the failure to unlock a spin lock in a error
path.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 22:58:46 -05:00
Larry Finger
efddeb40e2 rtl8188eu: Fix Sparse warnings in core/rtw_mlme.c
Sparse reports the following:

  CHECK   /home/finger/rtl8188eu/core/rtw_mlme.c
/home/finger/rtl8188eu/core/rtw_mlme.c💯6: warning: symbol 'rtw_mfree_mlme_priv_lock' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme.c:481:9: warning: symbol 'rtw_enqueue_network' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_mlme.c:510:6: warning: symbol 'rtw_free_network' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 20:13:44 -05:00
Larry Finger
124237abfb rtl8188eu: Fix Sparse warnings
Sparse lists the following:

  CHECK   /home/finger/rtl8188eu/core/rtw_cmd.c
/home/finger/rtl8188eu/core/rtw_cmd.c:236:5: warning: symbol 'rtw_cmd_filter' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:1949:6: warning: symbol 'lps_ctrl_wk_hdl' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:2168:6: warning: symbol 'power_saving_wk_hdl' was not declared. Should it be static?
/home/finger/rtl8188eu/core/rtw_cmd.c:2744:6: warning: symbol 'rtw_getrttbl_cmd_cmdrsp_callback' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 19:46:40 -05:00
Larry Finger
76682b1874 rtl8188eu: Fix Fix Sparse warning in os_dep/os_intfs.c
Sparse issues the following:

  CHECK   /home/finger/rtl8188eu/os_dep/os_intfs.c
/home/finger/rtl8188eu/os_dep/os_intfs.c:647:4: warning: symbol 'rtw_init_default_value' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 19:40:02 -05:00
Larry Finger
c8bd30ee46 rtl8188eu: Fix Sparse errors in os_dep/ioctl_linux.c
The following Sparse warnings are output:

  CHECK   /home/finger/rtl8188eu/os_dep/ioctl_linux.c
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3184:9: warning: context imbalance in 'rtw_get_ap_info' - different lock contexts for basic block
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:3916:9: warning: context imbalance in 'rtw_p2p_get_go_device_address' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4063:9: warning: context imbalance in 'rtw_p2p_get_device_name' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:4146:9: warning: context imbalance in 'rtw_p2p_get_invitation_procedure' - wrong count at exit
/home/finger/rtl8188eu/os_dep/ioctl_linux.c:6879:12: warning: context imbalance in 'rtw_del_sta' - different lock contexts for basic block

Each of these is a real error caused by improper use of a spin lock when
 a spin unlock is needed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 19:35:20 -05:00
Larry Finger
16ab32d5e3 rtl8188eu: Make more little endian changes
The master branch works on PPC architecture, which is big endian; however,
v4.1.8-9499 fails to connect. Receiving is OK as scanning works, thus it is
close to working. These changes make the two branches agree on the endianess
of various header items.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-14 19:18:20 -05:00
Larry Finger
0160af01ca rtl8188eu: Fix build warning for kernel 4.1 and later
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-08-12 10:58:21 -05:00
Larry Finger
b5cf1b0cf3 rtl8188eu: On kernel 2.6.32, a NULL dereference was found
This bug was reported and debugged by GitHub user jdowells.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-05-15 15:23:44 -05:00
Larry Finger
d76cbb313d rtl8188eu: Replace rtw_ieee80211_ht_cap with standard kernel version
As shown in the previous commits, keeping alignment beetween the private header
and the kernel version is a problem. Solve the issue by using the kernel
version.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-04-08 13:43:40 -05:00
Larry Finger
496a632c98 rtl8188eu: Fix struct rtw_ieee80211_ht_cap
To work with hostapd, the length of rtw_ieee80211_ht_cap must match
that of the kernel's ieee80211_ht_cap. Two errors were found.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-04-07 10:25:43 -05:00
Larry Finger
be58a411b0 rtl8188eu: Enable LEDs
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-23 18:46:53 -05:00
Larry Finger
569af61929 rtl8188eu: Fix Makefile copying firmware to wrong directory
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-23 17:06:07 -05:00
Larry Finger
7162635d09 rtl8188eu: Remove typedef statements from include/ieee80211.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-18 13:12:26 -05:00
Larry Finger
7460f4b22a rtl8188eu: Remove most typedef statements from include/hal_intf.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-17 10:31:25 -05:00
Larry Finger
fa43f604b9 rtl8188eu: Remove typedef statement from include/sta_info.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-17 10:01:59 -05:00
Larry Finger
22afcbab09 rtl8188eu: Remove typedef statements from include/HalVerDef.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-17 09:57:29 -05:00
Larry Finger
8259a22027 rtl8188eu: Remove typedef statements from include/rtw_mp_ioctl.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 20:24:53 -05:00
Larry Finger
4547604302 rtl8188eu: Remove typedef statements in include/rtw_mp.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 20:14:52 -05:00
Larry Finger
067adff3fd rtl8188eu: Remove unused header files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 09:53:23 -05:00
Larry Finger
b2720d8002 rtl8188eu: Remove C90 comments from include/*.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 09:43:53 -05:00
Larry Finger
e2285839e9 rtl8188eu: Remove most typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-16 08:54:18 -05:00
Larry Finger
26b163f24f rtl8188eu: Remove typedef statements from include/rtw_rf.h and delete unused header files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-15 12:43:37 -05:00
Larry Finger
851dc8fff5 rtl8188eu: Remove typedef statements from include/wlan_bssdef.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-14 18:14:05 -05:00
Larry Finger
8a5e5024c0 rtl8188eu: Remove typedef statements from include/rtw_mlme_ext.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2015-03-13 17:25:11 -05:00