Commit graph

51 commits

Author SHA1 Message Date
Larry Finger
4769256ac2 rtl8188eu: Fix smatch warnings in core/rtw_cmd.c
Smatch reports the following warnings:
  CHECK   /home/finger/rtl8188eu/core/rtw_cmd.c
/home/finger/rtl8188eu/core/rtw_cmd.c:385 rtw_cmd_thread() error: buffer overflow 'wlancmds' 63 <= 63
/home/finger/rtl8188eu/core/rtw_cmd.c:403 rtw_cmd_thread() error: buffer overflow 'rtw_cmd_callback' 63 <= 63

These are caused by an off-by-one error using <= rather than <.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-09-05 12:03:09 -05:00
Larry Finger
a839bebbbd rtl8188eu: Fix checkpatch ERRORs in core/rtw_cmd.c
Some WARNINGs and CHECKs remain.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 14:49:25 -05:00
Larry Finger
1ada4e9170 rtl8188eu: Remove configuration parameter CONFIG_80211N_HT
This one will always be selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-27 10:56:06 -05:00
Larry Finger
a0911e4309 rtl8188eu: Remove RATE_ADAPTIVE_SUPPORT - this is selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 21:47:50 -05:00
Larry Finger
2bd2f4b4c8 rtl8188eu: Convert typedef for _adapter, etc.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 20:08:39 -05:00
Larry Finger
476eaf9a4e rtl8188eu: Convert typedef statements from include/odm_HWConfig.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-26 17:56:14 -05:00
Larry Finger
d8af6fff83 rtl8188eu: Convert typedef for _workitem to struct work_struct
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-25 11:02:03 -05:00
Larry Finger
689d01adf6 rtl8188eu: Convert typedef for _queue to struct __queue
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 17:55:38 -05:00
Larry Finger
dfb5277a29 rtl8188eu: Replace typedefs related to threads with standard kernel types
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 12:47:20 -05:00
Larry Finger
2685b52404 rtl8188eu: Replace several local size defines/typedefs with kernel header version
These include the following:

SIZE_T => size_t
SSIZE_T => ssize_t
SIZE_PTR => size_t

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-24 12:19:14 -05:00
Larry Finger
41ad3e27c6 rtl8188eu: Convert some typedef statements from include/osdep_service.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 22:39:20 -05:00
Larry Finger
a01908ab27 rtl8188eu: Convert the typedef statements in include/wlan_bssdef.h
One remains that I still do not know how to convert; however, it has been
moved to os_dep/ioctl_linux.c where it is used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-23 21:31:04 -05:00
Larry Finger
7c128d19a1 rtl8188eu: Convert "typedef struct {}LED_871x" to "struct PLED_871x"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-22 17:07:13 -05:00
Larry Finger
71bc916e05 rtl8188eu: Remove CONFIG_FW_MLMLE - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 22:06:42 -05:00
Larry Finger
dfe35fb489 rtl8188eu: Remove CONFIG_USB_VENDOR_REQ_MUTEX - not selected
This change made include/drv_conf.h and core/rtw_ioctl_query.c redundant.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 13:00:05 -05:00
Larry Finger
a3f602a144 rtl8188eu: Remove CONFIG_C2H_WK - defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-21 10:35:02 -05:00
Larry Finger
25fa855fea rtl8188eu: Remove CONFIG_EVENT_THREAD_MODE - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 23:31:27 -05:00
Larry Finger
0bf3328b82 rtl8188eu: Remove CONFIG_H2CLBK - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 22:09:49 -05:00
Larry Finger
b94361b3e2 rtl8188eu: Remove MP_FIRMWARE_OFFLOAD - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 22:05:48 -05:00
Larry Finger
c803b22c53 rtl8188eu: Remove CONFIG_STA_MODE_SCAN_UNDER_AP_MODE - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 21:59:59 -05:00
Larry Finger
974a768133 rtl8188eu: Remove CONFIG_FTP_PROTECT - not defined
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 17:26:42 -05:00
Larry Finger
d538ad412a rtl8188eu: Remove SUPPORT_HW_RFOFF_DETECTED
This parameter was selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 13:33:00 -05:00
Larry Finger
7333ca4047 rtl8188eu: Remove CONFIG_P2P_PS and CONFIG_P2P_REMOVE_GROUP_INFO
Both are defined whenever CONFIG_P2P is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-20 11:25:24 -05:00
Larry Finger
085a651d9c rtl8188eu: Remove CONFIG_MP_INCLUDED
This one is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:55:30 -05:00
Larry Finger
167e245287 rtl8188eu: Remove CONFIG_LPS
This parameter is defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:25:11 -05:00
Larry Finger
cf8cd84af0 rtl8188eu: Remove CONFIG_LPS_LCLK
This one is not defined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 21:12:05 -05:00
Larry Finger
f50db5cd2c rtl8188eu: Remove DBG_CONFIG_ERROR_DETECT
This variable is selected.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-19 17:05:40 -05:00
Larry Finger
9a0ed4ec27 rtl8188eu: Remove CONFIG_ACTIVE_KEEP_ALIVE_CHECK
This configuration variable is always set

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-18 23:30:35 -05:00
Larry Finger
baf9862596 rtl8188eu: CONFIG_BR_EXT is always selected
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-18 10:42:52 -05:00
Larry Finger
951757e916 rtl8188eu: Remove ANTENNA DIVERSITY configuration variables and dead code
These changes include the following:
1. CONFIG_SW_ANTENNA_DIVERSITY - not selected
2. CONFIG_HW_ANTENNA_DIVERSITY - selected
3. CONFIG_ANTENNA_DIVERSITY - selected

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-14 14:10:10 -05:00
Larry Finger
6583d55cd1 rtl8188eu: Remove dead code associated with CONFIG_INTEL_XXX
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-12 20:51:15 -05:00
Larry Finger
7c593a903d rtl8188eu: Remove dead code associated with CONFIG_CONCURRENT snd CONFIG_DUALMAC_CONCURRENT
These two configuration parameters are only associated with the RTL8192DU
device, and can be removed here.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 22:50:49 -05:00
Larry Finger
e79535e153 rtl8188eu: Remove dead code for CONFIG_TDLS
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 20:13:07 -05:00
Larry Finger
0e4009c999 rtl8188eu: Remove dead code for other than USB
The vendor code has pieces of code for PCI, SDIO, and GSPI. Remove it
and CONFIG_USB_HCI.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 13:35:36 -05:00
Larry Finger
c5e461c221 rtl8188eu: Remove configuration parameters and dead code for other devices
The vendor code includes some code that is needed for RTL8182CU, RTL8192DU,
RTL8711, RTL8712, and RTL8723AU. This dead code is removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-11 10:59:02 -05:00
Larry Finger
a3ca3380b5 rtl8188eu: Remove dead code used for PLATFORM_WINDOWS, PLATFORM_OS_XP, and PLATFORM_OS_CE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-10 20:46:15 -05:00
Larry Finger
d2c90ee304 rtl8188eu: Change C90 comments to kernel form for files in core/
This commit also includes some sparse fixes for endian issues.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-07-09 17:38:46 -05:00
Larry Finger
fb786d0283 rtl8188eu: Fix all W=1 warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-21 13:41:29 -05:00
Larry Finger
327817d32a rtl8188eu: Fix most sparse warnings other than endedness problems
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-06-03 14:52:18 -05:00
Larry Finger
4342c7358c rtl8188eu: Fix some sparse errors
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-27 17:32:24 -05:00
Larry Finger
9cef34aa09 rtl8188eu: Change _FALSE and _TRUE to false and true
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 22:02:10 -05:00
Larry Finger
96adb823b9 rtl8188eu: Update logging
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-25 18:35:42 -05:00
Larry Finger
f5f3863bc5 rtl8188eu: Remove trailing white space from all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 23:28:07 -05:00
Larry Finger
77e736c66a rtl8188eu: Remove dead code inside #if 0 ... #endif
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-18 16:16:10 -05:00
Larry Finger
d928fd343d rtl8188eu: drop private endian framework
These changes are based on the similar modifications made by
Stefan Lippers-Hollmann for the rtl8192du driver.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-15 12:38:25 -05:00
Larry Finger
300892ebfd Fix some of the sparse warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-09 16:00:41 -05:00
Larry Finger
d4fa4d178f Replace __FUNCTION__ with __func__
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-09 11:23:32 -05:00
Larry Finger
4620c2a956 Remove the execute privilege bit on all source files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:36:05 -05:00
Larry Finger
d25660e511 Remove space before \n in formats
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:09:18 -05:00
Larry Finger
a55f866a62 Change "if(" to "if (" and the same changes for "while", "for", "switch" and "do"
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2013-05-08 23:04:25 -05:00